code review 171770043: cmd/gc: logical operators should produce untyped bool f...

cmd/gc: logical operators should produce untyped bool for untyped operands

Fixes issue 6671 for cmd/gc.

[cmang, 2014-10-31 20:32:30]

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com, gri@golang.org),

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2014-10-31 20:59:36]

LGTM but for go 1.5

please wait until the 1.5 cycle.

https://codereview.appspot.com/171770043/diff/60001/src/cmd/gc/typecheck.c
File src/cmd/gc/typecheck.c (right):

https://codereview.appspot.com/171770043/diff/60001/src/cmd/gc/typecheck.c#ne...
src/cmd/gc/typecheck.c:650: else if(l->type == idealbool || r->type ==
idealbool) {
might as well write this as

else if(l->type == idealbool)
    t = r->type;
else if(r->type == idealbool)
    t = l->type;

[cmang, 2014-10-31 21:02:57]

https://codereview.appspot.com/171770043/diff/60001/src/cmd/gc/typecheck.c
File src/cmd/gc/typecheck.c (right):

https://codereview.appspot.com/171770043/diff/60001/src/cmd/gc/typecheck.c#ne...
src/cmd/gc/typecheck.c:650: else if(l->type == idealbool || r->type ==
idealbool) {
On 2014/10/31 20:59:35, rsc wrote:
> might as well write this as
> 
> else if(l->type == idealbool)
>     t = r->type;
> else if(r->type == idealbool)
>     t = l->type;

Done.

[gobot, 2014-12-19 05:15:46]

R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/171770043 is best) in the description in your
new CL.

Thanks very much.