Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(166)

Issue 171048: Add a Makefile in place of all.bash (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 3 months ago by dho
Modified:
15 years, 3 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

Add a Makefile in place of all.bash. Update docs to reflect this change.

Patch Set 1 #

Patch Set 2 : code review 171048: Add a Makefile in place of all.bash. Update docs to reflect #

Total comments: 1

Patch Set 3 : code review 171048: Add a Makefile in place of all.bash. Update docs to reflect #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M doc/code.html View 1 chunk +2 lines, -2 lines 0 comments Download
M doc/contribute.html View 2 1 chunk +2 lines, -2 lines 0 comments Download
M doc/install.html View 1 chunk +2 lines, -2 lines 0 comments Download
A src/Makefile View 1 1 chunk +11 lines, -0 lines 0 comments Download
M src/all.bash View 1 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 5
rsc
Please update the instructions in $GOROOT/doc to remove the references to all.bash. all.bash needs to ...
15 years, 3 months ago (2009-12-11 18:59:34 UTC) #1
dho
2009/12/11 <rsc@golang.org>: > Please update the instructions in $GOROOT/doc to > remove the references to ...
15 years, 3 months ago (2009-12-11 20:04:34 UTC) #2
rsc
http://codereview.appspot.com/171048/diff/1003/2002 File doc/contribute.html (right): http://codereview.appspot.com/171048/diff/1003/2002#newcode24 doc/contribute.html:24: ./make all drop the ./
15 years, 3 months ago (2009-12-11 20:36:26 UTC) #3
dho
2009/12/11 <rsc@golang.org>: > > http://codereview.appspot.com/171048/diff/1003/2002 > File doc/contribute.html (right): > > http://codereview.appspot.com/171048/diff/1003/2002#newcode24 > doc/contribute.html:24: ./make ...
15 years, 3 months ago (2009-12-11 20:38:09 UTC) #4
rsc
15 years, 3 months ago (2009-12-11 20:49:01 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=2cfea7884617 ***

Add a Makefile in place of all.bash. Update docs to reflect
this change.

R=rsc
CC=golang-dev
http://codereview.appspot.com/171048

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b