code review 171000043: go.crypto/ssh/terminal: remove \r from passwords on Windows.

go.crypto/ssh/terminal: remove \r from passwords on Windows.

Fixes issue 9040.

(Note: can't compile or test this one prior to committing.)

[agl1, 2014-11-03 22:28:12]

Hello bradfitz@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.crypto

[mathias.gumz, 2014-11-03 22:42:25]

On 2014/11/03 22:28:12, agl1 wrote:
> Hello mailto:bradfitz@golang.org (cc:
mailto:golang-codereviews@googlegroups.com),
> 
> I'd like you to review this change to
> https://code.google.com/p/go.crypto

just fyi: compiles and solves the problem on my windows64.

[iant, 2014-11-03 23:49:47]

LGTM

[bradfitz, 2014-11-04 04:14:56]

LGTM
 On Nov 3, 2014 7:28 PM, <agl@golang.org> wrote:

> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz@golang.org (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go.crypto
>
>
> Description:
> go.crypto/ssh/terminal: remove \r from passwords on Windows.
>
> Fixes issue 9040.
>
> (Note: can't compile or test this one prior to committing.)
>
> Please review this at https://codereview.appspot.com/171000043/
>
> Affected files (+3, -0 lines):
>   M ssh/terminal/util_windows.go
>
>
> Index: ssh/terminal/util_windows.go
> ===================================================================
> --- a/ssh/terminal/util_windows.go
> +++ b/ssh/terminal/util_windows.go
> @@ -161,6 +161,9 @@
>                 if buf[n-1] == '\n' {
>                         n--
>                 }
> +               if n > 0 && buf[n-1] == '\r' {
> +                       n--
> +               }
>                 ret = append(ret, buf[:n]...)
>                 if n < len(buf) {
>                         break
>
>
>

[agl1, 2014-11-04 18:58:15]

*** Submitted as
https://code.google.com/p/go/source/detail?r=88f995681294&repo=crypto ***

go.crypto/ssh/terminal: remove \r from passwords on Windows.

Fixes issue 9040.

(Note: can't compile or test this one prior to committing.)

LGTM=iant, bradfitz
R=bradfitz, mathias.gumz, iant
CC=golang-codereviews
https://codereview.appspot.com/171000043