code review 170920043: go.tools: use golang.org/x/... import paths

go.tools: use golang.org/x/... import paths

Rewrite performed with this command:
  sed -i '' 's_code.google.com/p/go\._golang.org/x/_g' \
    $(grep -lr 'code.google.com/p/go.' *)

[adg, 2014-11-02 00:50:37]

Hello rsc, rsc@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.tools

[rsc, 2014-11-02 02:43:08]

Please wait to introduce any references to the golang.org/x repos until
we've had a chance to talk about the sequencing at the release meeting.
Thanks.


On Sat Nov 01 2014 at 8:50:38 PM <adg@golang.org> wrote:

> Reviewers: rsc,
>
> Message:
> Hello rsc, rsc@golang.org (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go.tools
>
>
> Description:
> go.tools: use golang.org/x/... import paths
>
> Please review this at https://codereview.appspot.com/170920043/
>
> Affected files (+444, -444 lines):
>    M astutil/enclosing_test.go
>    M blog/blog.go
>    M cmd/cover/func.go
>    M cmd/cover/html.go
>    M cmd/digraph/digraph.go
>    M cmd/eg/eg.go
>    M cmd/godex/doc.go
>    M cmd/godex/gc.go
>    M cmd/godex/gccgo.go
>    M cmd/godex/godex.go
>    M cmd/godex/print.go
>    M cmd/godex/source.go
>    M cmd/godex/writetype.go
>    M cmd/godoc/README.godoc-app
>    M cmd/godoc/appinit.go
>    M cmd/godoc/blog.go
>    M cmd/godoc/codewalk.go
>    M cmd/godoc/handlers.go
>    M cmd/godoc/main.go
>    M cmd/godoc/play.go
>    M cmd/godoc/setup-godoc-app.bash
>    M cmd/goimports/doc.go
>    M cmd/goimports/goimports.go
>    M cmd/gorename/main.go
>    M cmd/gotype/gotype.go
>    M cmd/html2article/conv.go
>    M cmd/oracle/emacs-test.bash
>    M cmd/oracle/main.go
>    M cmd/oracle/oracle.el
>    M cmd/present/appengine.go
>    M cmd/present/dir.go
>    M cmd/present/doc.go
>    M cmd/present/local.go
>    M cmd/present/play.go
>    M cmd/ssadump/main.go
>    M cmd/stringer/stringer.go
>    M cmd/vet/composite.go
>    M cmd/vet/copylock.go
>    M cmd/vet/main.go
>    M cmd/vet/nilfunc.go
>    M cmd/vet/print.go
>    M cmd/vet/shadow.go
>    M cmd/vet/shift.go
>    M cmd/vet/types.go
>    M cmd/vet/unsafeptr.go
>    M container/intsets/sparse_test.go
>    M dashboard/app/build/dash.go
>    M dashboard/app/build/test.go
>    M dashboard/builder/env.go
>    M dashboard/builder/main.go
>    M dashboard/builder/vcs.go
>    M dashboard/env/linux-x86-base/scripts/build-go-builder.sh
>    M dashboard/env/linux-x86-clang/scripts/build-go-builder.sh
>    M dashboard/env/linux-x86-nacl/scripts/build-go-builder.sh
>    M dashboard/env/linux-x86-sid/scripts/build-go-builder.sh
>    M dashboard/watcher/watcher.go
>    M go/buildutil/allpackages_test.go
>    M go/buildutil/util_test.go
>    M go/callgraph/callgraph.go
>    M go/callgraph/util.go
>    M go/gccgoimporter/gccgoinstallation.go
>    M go/gccgoimporter/gccgoinstallation_test.go
>    M go/gccgoimporter/importer.go
>    M go/gccgoimporter/importer_test.go
>    M go/gccgoimporter/parser.go
>    M go/gccgoimporter/parser_test.go
>    M go/gcimporter/gcimporter.go
>    M go/gcimporter/gcimporter_test.go
>    M go/importer/export.go
>    M go/importer/import.go
>    M go/importer/import_test.go
>    M go/importer/predefined.go
>    M go/loader/loader.go
>    M go/loader/loader_test.go
>    M go/loader/source_test.go
>    M go/loader/stdlib_test.go
>    M go/pointer/analysis.go
>    M go/pointer/api.go
>    M go/pointer/callgraph.go
>    M go/pointer/constraint.go
>    M go/pointer/example_test.go
>    M go/pointer/gen.go
>    M go/pointer/hvn.go
>    M go/pointer/intrinsics.go
>    M go/pointer/labels.go
>    M go/pointer/pointer_test.go
>    M go/pointer/reflect.go
>    M go/pointer/solve.go
>    M go/pointer/stdlib_test.go
>    M go/pointer/util.go
>    M go/ssa/builder.go
>    M go/ssa/builder_test.go
>    M go/ssa/const.go
>    M go/ssa/create.go
>    M go/ssa/emit.go
>    M go/ssa/example_test.go
>    M go/ssa/func.go
>    M go/ssa/interp/external.go
>    M go/ssa/interp/interp.go
>    M go/ssa/interp/interp_test.go
>    M go/ssa/interp/map.go
>    M go/ssa/interp/ops.go
>    M go/ssa/interp/reflect.go
>    M go/ssa/interp/value.go
>    M go/ssa/lift.go
>    M go/ssa/lvalue.go
>    M go/ssa/methods.go
>    M go/ssa/print.go
>    M go/ssa/sanity.go
>    M go/ssa/source.go
>    M go/ssa/source_test.go
>    M go/ssa/ssa.go
>    M go/ssa/ssautil/switch.go
>    M go/ssa/ssautil/switch_test.go
>    M go/ssa/ssautil/visit.go
>    M go/ssa/stdlib_test.go
>    M go/ssa/testmain.go
>    M go/ssa/testmain_test.go
>    M go/ssa/util.go
>    M go/ssa/wrappers.go
>    M go/types/api.go
>    M go/types/api_test.go
>    M go/types/builtins.go
>    M go/types/builtins_test.go
>    M go/types/check.go
>    M go/types/check_test.go
>    M go/types/conversions.go
>    M go/types/decl.go
>    M go/types/eval.go
>    M go/types/eval_test.go
>    M go/types/expr.go
>    M go/types/exprstring_test.go
>    M go/types/hilbert_test.go
>    M go/types/issues_test.go
>    M go/types/object.go
>    M go/types/operand.go
>    M go/types/resolver.go
>    M go/types/resolver_test.go
>    M go/types/self_test.go
>    M go/types/stdlib_test.go
>    M go/types/stmt.go
>    M go/types/typestring_test.go
>    M go/types/typeutil/imports.go
>    M go/types/typeutil/imports_test.go
>    M go/types/typeutil/map.go
>    M go/types/typeutil/map_test.go
>    M go/types/typeutil/ui.go
>    M go/types/typexpr.go
>    M go/types/universe.go
>    M godoc/analysis/analysis.go
>    M godoc/analysis/callgraph.go
>    M godoc/analysis/implements.go
>    M godoc/analysis/peers.go
>    M godoc/analysis/typeinfo.go
>    M godoc/cmdline.go
>    M godoc/cmdline_test.go
>    M godoc/corpus.go
>    M godoc/index.go
>    M godoc/index_test.go
>    M godoc/meta.go
>    M godoc/parser.go
>    M godoc/pres.go
>    M godoc/redirect/redirect.go
>    M godoc/server.go
>    M godoc/static/doc.go
>    M godoc/static/package.html
>    M godoc/static/static.go
>    M godoc/template.go
>    M godoc/util/util.go
>    M godoc/vfs/gatefs/gatefs.go
>    M godoc/vfs/httpfs/httpfs.go
>    M godoc/vfs/mapfs/mapfs.go
>    M godoc/vfs/zipfs/zipfs.go
>    M imports/fix.go
>    M imports/imports.go
>    M oracle/callees.go
>    M oracle/callers.go
>    M oracle/callgraph.go
>    M oracle/callstack.go
>    M oracle/definition.go
>    M oracle/describe.go
>    M oracle/freevars.go
>    M oracle/implements.go
>    M oracle/oracle.go
>    M oracle/oracle_test.go
>    M oracle/peers.go
>    M oracle/pointsto.go
>    M oracle/pos.go
>    M oracle/referrers.go
>    M oracle/what.go
>    M playground/socket/socket.go
>    M refactor/README
>    M refactor/eg/eg.go
>    M refactor/eg/eg_test.go
>    M refactor/eg/match.go
>    M refactor/eg/rewrite.go
>    M refactor/importgraph/graph.go
>    M refactor/importgraph/graph_test.go
>    M refactor/lexical/lexical.go
>    M refactor/lexical/lexical_test.go
>    M refactor/rename/check.go
>    M refactor/rename/rename.el
>    M refactor/rename/rename.go
>    M refactor/rename/spec.go
>    M refactor/rename/util.go
>    M refactor/satisfy/find.go
>
>
>

[adg, 2014-11-02 04:00:44]

Sure thing. FWIW, with this and the changes to the net and text sub-repos,
everything builds, tests, and seems to work correctly.

On Sun Nov 02 2014 at 1:43:11 PM Russ Cox <rsc@golang.org> wrote:

> Please wait to introduce any references to the golang.org/x repos until
> we've had a chance to talk about the sequencing at the release meeting.
> Thanks.
>
>
> On Sat Nov 01 2014 at 8:50:38 PM <adg@golang.org> wrote:
>
>> Reviewers: rsc,
>>
>> Message:
>> Hello rsc, rsc@golang.org (cc: golang-codereviews@googlegroups.com),
>>
>> I'd like you to review this change to
>> https://code.google.com/p/go.tools
>>
>>
>> Description:
>> go.tools: use golang.org/x/... import paths
>>
>> Please review this at https://codereview.appspot.com/170920043/
>>
>> Affected files (+444, -444 lines):
>>    M astutil/enclosing_test.go
>>    M blog/blog.go
>>    M cmd/cover/func.go
>>    M cmd/cover/html.go
>>    M cmd/digraph/digraph.go
>>    M cmd/eg/eg.go
>>    M cmd/godex/doc.go
>>    M cmd/godex/gc.go
>>    M cmd/godex/gccgo.go
>>    M cmd/godex/godex.go
>>    M cmd/godex/print.go
>>    M cmd/godex/source.go
>>    M cmd/godex/writetype.go
>>    M cmd/godoc/README.godoc-app
>>    M cmd/godoc/appinit.go
>>    M cmd/godoc/blog.go
>>    M cmd/godoc/codewalk.go
>>    M cmd/godoc/handlers.go
>>    M cmd/godoc/main.go
>>    M cmd/godoc/play.go
>>    M cmd/godoc/setup-godoc-app.bash
>>    M cmd/goimports/doc.go
>>    M cmd/goimports/goimports.go
>>    M cmd/gorename/main.go
>>    M cmd/gotype/gotype.go
>>    M cmd/html2article/conv.go
>>    M cmd/oracle/emacs-test.bash
>>    M cmd/oracle/main.go
>>    M cmd/oracle/oracle.el
>>    M cmd/present/appengine.go
>>    M cmd/present/dir.go
>>    M cmd/present/doc.go
>>    M cmd/present/local.go
>>    M cmd/present/play.go
>>    M cmd/ssadump/main.go
>>    M cmd/stringer/stringer.go
>>    M cmd/vet/composite.go
>>    M cmd/vet/copylock.go
>>    M cmd/vet/main.go
>>    M cmd/vet/nilfunc.go
>>    M cmd/vet/print.go
>>    M cmd/vet/shadow.go
>>    M cmd/vet/shift.go
>>    M cmd/vet/types.go
>>    M cmd/vet/unsafeptr.go
>>    M container/intsets/sparse_test.go
>>    M dashboard/app/build/dash.go
>>    M dashboard/app/build/test.go
>>    M dashboard/builder/env.go
>>    M dashboard/builder/main.go
>>    M dashboard/builder/vcs.go
>>    M dashboard/env/linux-x86-base/scripts/build-go-builder.sh
>>    M dashboard/env/linux-x86-clang/scripts/build-go-builder.sh
>>    M dashboard/env/linux-x86-nacl/scripts/build-go-builder.sh
>>    M dashboard/env/linux-x86-sid/scripts/build-go-builder.sh
>>    M dashboard/watcher/watcher.go
>>    M go/buildutil/allpackages_test.go
>>    M go/buildutil/util_test.go
>>    M go/callgraph/callgraph.go
>>    M go/callgraph/util.go
>>    M go/gccgoimporter/gccgoinstallation.go
>>    M go/gccgoimporter/gccgoinstallation_test.go
>>    M go/gccgoimporter/importer.go
>>    M go/gccgoimporter/importer_test.go
>>    M go/gccgoimporter/parser.go
>>    M go/gccgoimporter/parser_test.go
>>    M go/gcimporter/gcimporter.go
>>    M go/gcimporter/gcimporter_test.go
>>    M go/importer/export.go
>>    M go/importer/import.go
>>    M go/importer/import_test.go
>>    M go/importer/predefined.go
>>    M go/loader/loader.go
>>    M go/loader/loader_test.go
>>    M go/loader/source_test.go
>>    M go/loader/stdlib_test.go
>>    M go/pointer/analysis.go
>>    M go/pointer/api.go
>>    M go/pointer/callgraph.go
>>    M go/pointer/constraint.go
>>    M go/pointer/example_test.go
>>    M go/pointer/gen.go
>>    M go/pointer/hvn.go
>>    M go/pointer/intrinsics.go
>>    M go/pointer/labels.go
>>    M go/pointer/pointer_test.go
>>    M go/pointer/reflect.go
>>    M go/pointer/solve.go
>>    M go/pointer/stdlib_test.go
>>    M go/pointer/util.go
>>    M go/ssa/builder.go
>>    M go/ssa/builder_test.go
>>    M go/ssa/const.go
>>    M go/ssa/create.go
>>    M go/ssa/emit.go
>>    M go/ssa/example_test.go
>>    M go/ssa/func.go
>>    M go/ssa/interp/external.go
>>    M go/ssa/interp/interp.go
>>    M go/ssa/interp/interp_test.go
>>    M go/ssa/interp/map.go
>>    M go/ssa/interp/ops.go
>>    M go/ssa/interp/reflect.go
>>    M go/ssa/interp/value.go
>>    M go/ssa/lift.go
>>    M go/ssa/lvalue.go
>>    M go/ssa/methods.go
>>    M go/ssa/print.go
>>    M go/ssa/sanity.go
>>    M go/ssa/source.go
>>    M go/ssa/source_test.go
>>    M go/ssa/ssa.go
>>    M go/ssa/ssautil/switch.go
>>    M go/ssa/ssautil/switch_test.go
>>    M go/ssa/ssautil/visit.go
>>    M go/ssa/stdlib_test.go
>>    M go/ssa/testmain.go
>>    M go/ssa/testmain_test.go
>>    M go/ssa/util.go
>>    M go/ssa/wrappers.go
>>    M go/types/api.go
>>    M go/types/api_test.go
>>    M go/types/builtins.go
>>    M go/types/builtins_test.go
>>    M go/types/check.go
>>    M go/types/check_test.go
>>    M go/types/conversions.go
>>    M go/types/decl.go
>>    M go/types/eval.go
>>    M go/types/eval_test.go
>>    M go/types/expr.go
>>    M go/types/exprstring_test.go
>>    M go/types/hilbert_test.go
>>    M go/types/issues_test.go
>>    M go/types/object.go
>>    M go/types/operand.go
>>    M go/types/resolver.go
>>    M go/types/resolver_test.go
>>    M go/types/self_test.go
>>    M go/types/stdlib_test.go
>>    M go/types/stmt.go
>>    M go/types/typestring_test.go
>>    M go/types/typeutil/imports.go
>>    M go/types/typeutil/imports_test.go
>>    M go/types/typeutil/map.go
>>    M go/types/typeutil/map_test.go
>>    M go/types/typeutil/ui.go
>>    M go/types/typexpr.go
>>    M go/types/universe.go
>>    M godoc/analysis/analysis.go
>>    M godoc/analysis/callgraph.go
>>    M godoc/analysis/implements.go
>>    M godoc/analysis/peers.go
>>    M godoc/analysis/typeinfo.go
>>    M godoc/cmdline.go
>>    M godoc/cmdline_test.go
>>    M godoc/corpus.go
>>    M godoc/index.go
>>    M godoc/index_test.go
>>    M godoc/meta.go
>>    M godoc/parser.go
>>    M godoc/pres.go
>>    M godoc/redirect/redirect.go
>>    M godoc/server.go
>>    M godoc/static/doc.go
>>    M godoc/static/package.html
>>    M godoc/static/static.go
>>    M godoc/template.go
>>    M godoc/util/util.go
>>    M godoc/vfs/gatefs/gatefs.go
>>    M godoc/vfs/httpfs/httpfs.go
>>    M godoc/vfs/mapfs/mapfs.go
>>    M godoc/vfs/zipfs/zipfs.go
>>    M imports/fix.go
>>    M imports/imports.go
>>    M oracle/callees.go
>>    M oracle/callers.go
>>    M oracle/callgraph.go
>>    M oracle/callstack.go
>>    M oracle/definition.go
>>    M oracle/describe.go
>>    M oracle/freevars.go
>>    M oracle/implements.go
>>    M oracle/oracle.go
>>    M oracle/oracle_test.go
>>    M oracle/peers.go
>>    M oracle/pointsto.go
>>    M oracle/pos.go
>>    M oracle/referrers.go
>>    M oracle/what.go
>>    M playground/socket/socket.go
>>    M refactor/README
>>    M refactor/eg/eg.go
>>    M refactor/eg/eg_test.go
>>    M refactor/eg/match.go
>>    M refactor/eg/rewrite.go
>>    M refactor/importgraph/graph.go
>>    M refactor/importgraph/graph_test.go
>>    M refactor/lexical/lexical.go
>>    M refactor/lexical/lexical_test.go
>>    M refactor/rename/check.go
>>    M refactor/rename/rename.el
>>    M refactor/rename/rename.go
>>    M refactor/rename/spec.go
>>    M refactor/rename/util.go
>>    M refactor/satisfy/find.go
>>
>>
>>

[adg, 2014-11-05 23:28:26]

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com),

Please take another look.

[rsc, 2014-11-06 01:52:05]

LGTM sunday

[adg, 2014-11-09 21:50:44]

*** Submitted as
https://code.google.com/p/go/source/detail?r=ae08a5291439&repo=tools ***

go.tools: use golang.org/x/... import paths

Rewrite performed with this command:
  sed -i '' 's_code.google.com/p/go\._golang.org/x/_g' \
    $(grep -lr 'code.google.com/p/go.' *)

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/170920043