Issue 170850043: code review 170850043: misc: Increase issue 6997's test timeout to prevent spu...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 170850043: code review 170850043: misc: Increase issue 6997's test timeout to prevent spu...

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 5 months ago by tsuna

Modified:
9 years, 5 months ago

Reviewers:
iant

CC:
iant, golang-codereviews, sqweek

Visibility:
Public.

Description

misc: Increase issue 6997's test timeout to prevent spurious failures. On heavily loaded build servers, a 5 second timeout is too aggressive, which causes this test to fail spuriously.

Patch Set 1 #

Patch Set 2 : diff -r cbe771d7fb7ec64e4a062ac99edf7b01d211c621 https://code.google.com/p/go/ #

Patch Set 3 : diff -r cbe771d7fb7ec64e4a062ac99edf7b01d211c621 https://code.google.com/p/go/ #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	misc/cgo/test/issue6997_linux.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

tsuna

Hello iant@golang.org (cc: golang-codereviews@googlegroups.com, sqweek@gmail.com), I'd like you to review this change to https://code.google.com/p/go/

9 years, 5 months ago (2014-10-31 17:58:56 UTC) #1

tsuna

On 2014/10/31 22:59:30, iant wrote: > Thanks. Have you signed the CLA? Now yes.

9 years, 5 months ago (2014-10-31 23:01:40 UTC) #3

iant

9 years, 5 months ago (2014-11-01 15:28:09 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=53ebc70d4e9f ***

misc: Increase issue 6997's test timeout to prevent spurious failures.

On heavily loaded build servers, a 5 second timeout is too aggressive,
which causes this test to fail spuriously.

LGTM=iant
R=iant
CC=golang-codereviews, sqweek
https://codereview.appspot.com/170850043

Committer: Ian Lance Taylor <iant@golang.org>

Expand All Messages | Collapse All Messages