Issue 1704044: code review 1704044: strings and bytes.Split: make count of 0 mean 0, not in...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1704044: code review 1704044: strings and bytes.Split: make count of 0 mean 0, not in... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by r

Modified:
13 years, 7 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

strings and bytes.Split: make count of 0 mean 0, not infinite. Use a count of -1 for infinity. Ditto for Replace.

Patch Set 1 #

Patch Set 2 : code review 1704044: strings and bytes.Split: make count of 0 mean 0, not in... #

Patch Set 3 : code review 1704044: strings and bytes.Split: make count of 0 mean 0, not in... #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+122 lines, -97 lines)			Patch
M	src/cmd/cgo/gcc.go	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/cmd/godoc/godoc.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/cmd/godoc/index.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/godoc/mapping.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gofmt/rewrite.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/hgpatch/main.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/asn1/common.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/bytes/bytes.go	View	1	3 chunks	+11 lines, -3 lines	0 comments	Download
M	src/pkg/bytes/bytes_test.go	View	1 2	5 chunks	+34 lines, -30 lines	0 comments	Download
M	src/pkg/crypto/x509/x509.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/exec/exec.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/nacl/srpc/client.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/ogle/cmd.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/go/doc/comment.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/http/request.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/http/transfer.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/nntp/nntp_test.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/patch/patch.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/rpc/server.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/strconv/fp_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/strings/strings.go	View	1	4 chunks	+15 lines, -7 lines	0 comments	Download
M	src/pkg/strings/strings_test.go	View	1 2	5 chunks	+34 lines, -29 lines	0 comments	Download
M	src/pkg/template/template.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/unicode/maketables.go	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 10 months ago (2010-07-01 03:25:55 UTC) #1

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 10 months ago (2010-07-01 03:58:13 UTC) #2

*** Submitted as http://code.google.com/p/go/source/detail?r=204e68060622 *** strings and bytes.Split: make count of 0 mean 0, not ...

13 years, 10 months ago (2010-07-01 21:08:17 UTC) #4

*** Abandoned ***

Expand All Messages | Collapse All Messages