[dev.cc] code review 170330043: runtime: convert basic library routines from C to Go

runtime: convert basic library routines from C to Go

float.c held bit patterns for special float64 values,
hiding from the real uses. Rewrite Go code not to
refer to those values directly.

Convert library routines in runtime.c and string.c.

[rsc, 2014-11-11 06:40:15]

Hello r (cc: austin, dvyukov, golang-codereviews@googlegroups.com, iant, khr),

I'd like you to review this change to the dev.cc branch of
https://code.google.com/p/go

[r, 2014-11-11 06:56:06]

LGTM

[dave_cheney.net, 2014-11-11 11:56:22]

https://codereview.appspot.com/170330043/diff/40001/src/runtime/runtime1.go
File src/runtime/runtime1.go (left):

https://codereview.appspot.com/170330043/diff/40001/src/runtime/runtime1.go#o...
src/runtime/runtime1.go:229: if(sizeof(void*) == 8)
There is a check for atomicor8 in the dev.power64 branch,

https://code.google.com/p/go/source/browse/src/runtime/runtime.c?name=dev.pow...

Can you please add it here so it is not lost.

https://codereview.appspot.com/170330043/diff/40001/src/runtime/runtime1.go
File src/runtime/runtime1.go (right):

https://codereview.appspot.com/170330043/diff/40001/src/runtime/runtime1.go#n...
src/runtime/runtime1.go:63: var (
Is this not needed, or just stubbed out now ?

[rsc, 2014-11-11 18:53:42]

https://codereview.appspot.com/170330043/diff/40001/src/runtime/runtime1.go
File src/runtime/runtime1.go (left):

https://codereview.appspot.com/170330043/diff/40001/src/runtime/runtime1.go#o...
src/runtime/runtime1.go:229: if(sizeof(void*) == 8)
On 2014/11/11 11:56:22, dfc wrote:
> There is a check for atomicor8 in the dev.power64 branch,
> 
>
https://code.google.com/p/go/source/browse/src/runtime/runtime.c?name=dev.pow...
> 
> Can you please add it here so it is not lost.

Thanks. I'll add it when I merge with the power64 branch.

https://codereview.appspot.com/170330043/diff/40001/src/runtime/runtime1.go
File src/runtime/runtime1.go (right):

https://codereview.appspot.com/170330043/diff/40001/src/runtime/runtime1.go#n...
src/runtime/runtime1.go:63: var (
On 2014/11/11 11:56:22, dfc wrote:
> Is this not needed, or just stubbed out now ?

That's where it should be, but runtime.h was providing them via C. Now they are
in runtime2.go or something like that. But this is where they should eventually
land.

[rsc, 2014-11-11 22:07:15]

*** Submitted as https://code.google.com/p/go/source/detail?r=9f1fef9e8a95 ***

[dev.cc] runtime: convert basic library routines from C to Go

float.c held bit patterns for special float64 values,
hiding from the real uses. Rewrite Go code not to
refer to those values directly.

Convert library routines in runtime.c and string.c.

LGTM=r
R=r, dave
CC=austin, dvyukov, golang-codereviews, iant, khr
https://codereview.appspot.com/170330043