Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1828)

Issue 170043: code review 170043: added benchmarks to rand_test.go; (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 3 months ago by rog
Modified:
14 years, 3 months ago
Reviewers:
rsc
CC:
r, rsc
Visibility:
Public.

Description

added benchmarks to rand_test.go; removed superfluous field name in lockedSource.

Patch Set 1 #

Patch Set 2 : code review 170043: added benchmarks to rand_test.go; #

Patch Set 3 : code review 170043: added benchmarks to rand_test.go; #

Total comments: 3

Patch Set 4 : code review 170043: added benchmarks to rand_test.go; #

Patch Set 5 : code review 170043: added benchmarks to rand_test.go; #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M src/pkg/rand/rand_test.go View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 8
rog
Hello r, rsc, I'd like you to review the following change.
14 years, 3 months ago (2009-12-09 21:41:07 UTC) #1
r
http://codereview.appspot.com/170043/diff/6/8 File src/pkg/rand/rand_test.go (right): http://codereview.appspot.com/170043/diff/6/8#newcode319 src/pkg/rand/rand_test.go:319: for n := b.N / 10; n > 0; ...
14 years, 3 months ago (2009-12-09 21:44:25 UTC) #2
rsc
http://codereview.appspot.com/170043/diff/6/7 File src/pkg/rand/rand.go (right): http://codereview.appspot.com/170043/diff/6/7#newcode155 src/pkg/rand/rand.go:155: sync.Mutex; i'd rather leave this as lk sync.Mutex, so ...
14 years, 3 months ago (2009-12-09 21:48:25 UTC) #3
rog
2009/12/9 <rsc@golang.org>: > http://codereview.appspot.com/170043/diff/6/7#newcode155 > src/pkg/rand/rand.go:155: sync.Mutex; > i'd rather leave this as lk sync.Mutex, ...
14 years, 3 months ago (2009-12-09 21:57:53 UTC) #4
rsc
>> i'd rather leave this as lk sync.Mutex, so that > > fair enough. hg ...
14 years, 3 months ago (2009-12-09 22:06:35 UTC) #5
rog
2009/12/9 Russ Cox <rsc@golang.org>: >>> i'd rather leave this as lk sync.Mutex, so that >> ...
14 years, 3 months ago (2009-12-09 22:13:25 UTC) #6
rsc
LGTM
14 years, 3 months ago (2009-12-09 22:20:55 UTC) #7
rsc
14 years, 3 months ago (2009-12-09 22:23:45 UTC) #8
*** Submitted as http://code.google.com/p/go/source/detail?r=07e0eaf3c34c ***

added benchmarks to rand_test.go;
removed superfluous field name in lockedSource.

R=r, rsc
http://codereview.appspot.com/170043

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b