code review 170042: doc: split contribute.html into code.html and contribut...

doc: split contribute.html into code.html and contribute.html

[rsc, 2009-12-09 20:59:15]

Hello r,

I'd like you to review the following change.

[r, 2009-12-09 21:23:15]

http://codereview.appspot.com/170042/diff/1007/1008
File doc/code.html (right):

http://codereview.appspot.com/170042/diff/1007/1008#newcode14
doc/code.html:14: package or the creation of a major new package,
s/major //

http://codereview.appspot.com/170042/diff/1007/1008#newcode19
doc/code.html:19: has been written.
i'd like to see this encourage more mail.  most code reviews i see are
unheralded. drop words like major and significant and rewrite to flip the
default

http://codereview.appspot.com/170042/diff/1007/1008#newcode105
doc/code.html:105: <code>$GOROOT/src/pkg/</code> removed.
s/removed/prefix removed/

http://codereview.appspot.com/170042/diff/1007/1008#newcode124
doc/code.html:124: After creating a new package directory in the Go tree, add it
to the list in
s/After creating/If you create/

http://codereview.appspot.com/170042/diff/1007/1008#newcode154
doc/code.html:154: The Go tools impose a restriction that package names are
unique
s/The/At the moment, the

http://codereview.appspot.com/170042/diff/1007/1008#newcode191
doc/code.html:191: run <code>gotest one_test.go</code>.
benchmarks too

http://codereview.appspot.com/170042/diff/1007/1008#newcode195
doc/code.html:195: Before sending code out for review, make sure everything
this only applies inside the tree

http://codereview.appspot.com/170042/diff/1007/1008#newcode221
doc/code.html:221: </p>
link back to contribute

http://codereview.appspot.com/170042/diff/1007/1009
File doc/contribute.html (right):

http://codereview.appspot.com/170042/diff/1007/1009#newcode8
doc/contribute.html:8: <a href="install.html">installation instructions</a> and
s/$/ have/

http://codereview.appspot.com/170042/diff/1007/1009#newcode77
doc/contribute.html:77: you are a committer (see below), but Mercurial whines if
it is missing.
s/whines/complains/ (less judgmental)

http://codereview.appspot.com/170042/diff/1007/1009#newcode91
doc/contribute.html:91: associated with any address where you receive email.
including your existing google account. ha.

http://codereview.appspot.com/170042/diff/1007/1009#newcode471
doc/contribute.html:471: This rigamarole needs to be done only for your first
submission.
s/rigamarole/rigmarole/
(apparently it's the preferred spelling, although both are ok)

[rsc, 2009-12-09 21:44:48]

PTAL

[r, 2009-12-09 22:03:23]

LGTM

[rsc, 2009-12-09 22:05:18]

*** Submitted as http://code.google.com/p/go/source/detail?r=12420ba637ef ***

doc: split contribute.html into code.html and contribute.html

R=r
http://codereview.appspot.com/170042