code review 16990043: go.talks: new talk Go for Pythonistas

go.talks: new talk Go for Pythonistas

[francesc, 2013-10-25 03:48:28]

Hello adg@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.talks

[francesc, 2013-10-25 03:49:07]

I'll start translating this to Spanish tomorrow and I present it on
Saturday for startechconf in Chile.


On Fri, Oct 25, 2013 at 12:48 AM, <campoy@golang.org> wrote:

> Reviewers: adg,
>
> Message:
> Hello adg@golang.org (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go.**talks <https://code.google.com/p/go.talks>
>
>
> Description:
> go.talks: new talk Go for Pythonistas
>
> Please review this at
https://codereview.appspot.**com/16990043/<https://codereview.appspot.com/169...
>
> Affected files (+596, --4 lines):
>   A 2013/go4python.slide
>   A 2013/go4python/deco.go
>   A 2013/go4python/deco.py
>   A 2013/go4python/dyntyp.py
>   A 2013/go4python/fib-gen.go
>   A 2013/go4python/fib-gen.py
>   A 2013/go4python/fib-gen2.go
>   A 2013/go4python/fib.go
>   A 2013/go4python/fib.py
>   A 2013/go4python/img/duck.jpg
>   A 2013/go4python/img/fib-go.png
>   A 2013/go4python/img/fib-py.png
>   A 2013/go4python/img/funnelin.**jpg
>   A 2013/go4python/monkey.go
>   A 2013/go4python/monkey.py
>   A 2013/go4python/**typesandmethods.go
>
>
>


-- 
--
Francesc

[adg, 2013-10-28 08:52:38]

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide
File 2013/go4python.slide (right):

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:18: 1. Showing you how it's like Python
s/it's/Go is/

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:20: 2. Showing you how it's *NOT* like Python
maybe "_not_" ?

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:49: Static typing with deduced types
s/deduced/inferred/

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:56: Statical typed Python? Check Guido's
[[http://www.mypy-lang.org/][mypy]]
s/Statical /Statically-/

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:66: Actually, you can Google* it yourself
delete

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:68: (*or Bing it, if you prefer)
delete

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:72: - Deploying - missing dependencies
s/missing/managing/

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:80: Lots have been said, I won't add more.
"A lot has been said"

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:106: Have you ever heard of Fibonacci?
haha really?!

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:138: Based on *Go*routines* and *channels*
"goroutines"

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:140: - Go routines: very light processing actors (the
gophers)
"goroutine"

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:142: - Channels: typed, syncrhonized, thread-safe pipes
(the pipes)
"synchronized"

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:146: * Go routines to the rescue
etc etc

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:162: * Other concurrency patterns
"More about concurrency"

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:170: Defining a new type
A type declaration

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:174: A new method
A method declaration

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:194: func (s string) NoWay()
the core point is that you can only define methods on types within the same
package. no monkeypatching

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:238: Ways to add functionality to a function.
"add functionality to a function" reads poorly
"A convenient way to wrap a function"

[francesc, 2013-10-28 14:38:21]

Thanks for the comments.

What do you think about the talk on a more general level?

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide
File 2013/go4python.slide (right):

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:18: 1. Showing you how it's like Python
On 2013/10/28 08:52:38, adg wrote:
> s/it's/Go is/

Done.

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:20: 2. Showing you how it's *NOT* like Python
On 2013/10/28 08:52:38, adg wrote:
> maybe "_not_" ?

Done.

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:49: Static typing with deduced types
On 2013/10/28 08:52:38, adg wrote:
> s/deduced/inferred/

Done.

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:56: Statical typed Python? Check Guido's
[[http://www.mypy-lang.org/][mypy]]
On 2013/10/28 08:52:38, adg wrote:
> s/Statical /Statically-/

Done.

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:66: Actually, you can Google* it yourself
On 2013/10/28 08:52:38, adg wrote:
> delete

Done.

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:68: (*or Bing it, if you prefer)
On 2013/10/28 08:52:38, adg wrote:
> delete

Done.

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:72: - Deploying - missing dependencies
On 2013/10/28 08:52:38, adg wrote:
> s/missing/managing/

Done.

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:80: Lots have been said, I won't add more.
On 2013/10/28 08:52:38, adg wrote:
> "A lot has been said"

Done.

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:106: Have you ever heard of Fibonacci?
On 2013/10/28 08:52:38, adg wrote:
> haha really?!

Geek humor, people love it :)

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:138: Based on *Go*routines* and *channels*
On 2013/10/28 08:52:38, adg wrote:
> "goroutines"

Done.

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:140: - Go routines: very light processing actors (the
gophers)
On 2013/10/28 08:52:38, adg wrote:
> "goroutine"

Done.

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:142: - Channels: typed, syncrhonized, thread-safe pipes
(the pipes)
On 2013/10/28 08:52:38, adg wrote:
> "synchronized"

Done.

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:146: * Go routines to the rescue
On 2013/10/28 08:52:38, adg wrote:
> etc etc

Done.

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:162: * Other concurrency patterns
On 2013/10/28 08:52:38, adg wrote:
> "More about concurrency"

Done.

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:170: Defining a new type
On 2013/10/28 08:52:38, adg wrote:
> A type declaration

Done.

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:174: A new method
On 2013/10/28 08:52:38, adg wrote:
> A method declaration

Done.

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:194: func (s string) NoWay()
On 2013/10/28 08:52:38, adg wrote:
> the core point is that you can only define methods on types within the same
> package. no monkeypatching

Done.

https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
2013/go4python.slide:238: Ways to add functionality to a function.
On 2013/10/28 08:52:38, adg wrote:
> "add functionality to a function" reads poorly
> "A convenient way to wrap a function"

Done.

[adg, 2013-10-31 07:47:19]

On 2013/10/28 14:38:21, gocampoy wrote:
> Thanks for the comments.
> 
> What do you think about the talk on a more general level?

I think it's pretty good. Seems to make some clear points.

>
https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
> 2013/go4python.slide:66: Actually, you can Google* it yourself
> On 2013/10/28 08:52:38, adg wrote:
> > delete
> 
> Done.

This doesn't seem done. Did you hg upload?

[francesc, 2013-11-01 22:58:04]

On 2013/10/31 07:47:19, adg wrote:
> On 2013/10/28 14:38:21, gocampoy wrote:
> > Thanks for the comments.
> > 
> > What do you think about the talk on a more general level?
> 
> I think it's pretty good. Seems to make some clear points.
> 
> >
>
https://codereview.appspot.com/16990043/diff/80001/2013/go4python.slide#newco...
> > 2013/go4python.slide:66: Actually, you can Google* it yourself
> > On 2013/10/28 08:52:38, adg wrote:
> > > delete
> > 
> > Done.
> 
> This doesn't seem done. Did you hg upload?

Done now

[adg, 2013-11-04 05:42:11]

More detailed feedback (Sorry for not sending this earlier)

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide
File 2013/go4python.slide (right):

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:34: * Things I don't like (it'll be short)
... about Python

it's not clear to the reader which language you're talking about

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:38: Dynamic typing - nice because it's concise
say this is python code

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:45: Static typing - can be verbose
mention this is Java or C++ code?

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:49: Static typing with inferred types
mention this is go code

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:58: * Interpreted evil
confusing title, maybe "Run time pyrotechnics" :-)

and add a line about the code snippet ("This code only works half the time.")

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:62: I don't want start a flame war here but ...
This point deserves its own slide.
And perhaps a little more explanation.
Remember these slides are for readers now.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:70: - Performance - "not too slow" doesn't mean fast enough
"not too slow" is often not fast enough

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:72: - Magic!
an example? elaborate maybe?
ironically, this magic bullet point makes you guilty of the thing you don't like
:)

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:74: * And ... the infamous GIL
* And I *do* like concurrency

A lot has been said about Python's infamous Global Interpreter Lock.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:96: - Magic!
again, a parenthetical listing some of these magic things might help

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:118: Conceptually complex
"Mechanically complex" perhaps?

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:138: - Channels: typed, synchronized, thread-safe pipes
(the pipes)
"(the pipes)" what pipes? all i see are arrows

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:142: * Goroutines to the rescue
What are they saving us from?

Maybe '"Generator" goroutines' is a better title

Also you could mention in words "Uses a channel send instead of yield."

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:158: * More about concurrency
This slide could say more. For example:

* But there's much more

Goroutines and channels aren't just for generators. They can be used to model
all kinds of concurrent systems.

To learn more:

- ... talks

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:164: * Types and methods
"Object-oriented Go" ?

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:164: * Types and methods
should there be a title slide before this one?

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:174: Using it
Constructing a `Name` and using it

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:192: You can define methods on types within the same
package.
You can *only* define...

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:206: s/duck/file-like object/g;
what's the semicolon for?

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:214: Just a set of methods.
Most interfaces define a set of methods. Why are Go's "just" that?

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:216: type Reader interface {
this could be fmt.Stringer instead, and you could show how the types from the
previous slide can be passed and formatted by fmt.Println

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:226: *Implicit*satisfaction*=*No*"implements"*
put this below the following statement

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:230: Structural typing: like duck typing, but checked at
compile time
Perhaps: It's called "Structural typing": it doesn't just sound like a duck; it
*is* a duck (and this is checked at compile time)

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:236: A convenient way to wrap a function.
you use closing punctuation on some slides but not on others. I don't mind which
way you go, but pick one and stick to it.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:254: Not really, but close enough.
"Go doesn't provide decorators in the language, but its function literal syntax
and simple scoping rules make it easy to do something similar.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:282: Mostly used for testing purposes
s/Mostly/Often/

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:284: We want to test
For example, say we want to test this function:

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:288: Which depends on
Which depends on a function that makes an HTTP request:

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:294: We can test `say_hi` without modifying it and without
HTTP requests.
We can test `say_hi` without making HTTP requests by stubbing out the auth
function:

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:300: The same effect can be obtained in Go.
s/obtained/achieved/

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:314: If the code is in a file with name ending in
`_test.go`, it's only compiled when running
This is kinda out-of-place. you haven't talked about packages or anything yet.
I'd consider dropping this point. It's a bad practice to stub stuff out for
_all_ tests all the time, anyway. Usually you'd want to do it just for that one
test and then put the original function back once it completes.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:316: go test
$ go test

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:334: - speed
fast

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:335: - concurrency
concurrent

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:339: - No animals (gophers, pythons, ducks, or monkeys)
were injured during the writing of this talk.
"No pythons, ducks, monkeys or gophers were harmed while writing this talk"

Sorry to reword your joke, but I think this flows better :-)

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:347: The interactive tour
Learn Go from your web browser

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:353: .link https://groups.google.com/d/forum/Golang-Nuts
no capitals

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/deco.go
File 2013/go4python/deco.go (right):

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/deco.go#ne...
2013/go4python/deco.go:21: var authSayHi = authRequired(sayHi)
you don't necessarily need a new name, this could be

var sayHi = authRequired(func() {
    fmt.Printf("Hi, %v", username)
})

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/deco.py
File 2013/go4python/deco.py (right):

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/deco.py#ne...
2013/go4python/deco.py:6: if username:
what is "username"? it's not clear on the slides
maybe you could use an http handler example instead?

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/fib-gen.go
File 2013/go4python/fib-gen.go (right):

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/fib-gen.go...
2013/go4python/fib-gen.go:5: func fib(n int, c chan int) {
i'd put the chan argument before the n argument
like io.Copy and fmt.Fprint, the destination comes first

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/fib-gen.go...
2013/go4python/fib-gen.go:9: c <- a // HL
not sure what these highlights are supposed to signify.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/fib-gen.go...
2013/go4python/fib-gen.go:15: c := make(chan int)
if you want to make it even more generator-like, why not have the fib function
create and return the channel, so the call site is just like python

for x := range fib(10) {
}

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/monkey.go
File 2013/go4python/monkey.go (right):

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/monkey.go#...
2013/go4python/monkey.go:15: func sayHi(usr string) {
s/usr/user/g

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/typesandme...
File 2013/go4python/typesandmethods.go (right):

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/typesandme...
2013/go4python/typesandmethods.go:14: func (n Name) Format() string {
s/Format/String/
It's a stringer!

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/typesandme...
2013/go4python/typesandmethods.go:20: func (s SimpleName) Format() string {
return string(s) }
ditto

[adg, 2013-11-04 05:42:13]

More detailed feedback (Sorry for not sending this earlier)

[francesc, 2013-11-06 03:51:14]

Comments taken into account and exercises added.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide
File 2013/go4python.slide (right):

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:34: * Things I don't like (it'll be short)
On 2013/11/04 05:42:12, adg wrote:
> ... about Python
> 
> it's not clear to the reader which language you're talking about

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:38: Dynamic typing - nice because it's concise
On 2013/11/04 05:42:12, adg wrote:
> say this is python code

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:45: Static typing - can be verbose
On 2013/11/04 05:42:12, adg wrote:
> mention this is Java or C++ code?

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:49: Static typing with inferred types
On 2013/11/04 05:42:12, adg wrote:
> mention this is go code

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:58: * Interpreted evil
On 2013/11/04 05:42:12, adg wrote:
> confusing title, maybe "Run time pyrotechnics" :-)
> 
> and add a line about the code snippet ("This code only works half the time.")

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:62: I don't want start a flame war here but ...
On 2013/11/04 05:42:12, adg wrote:
> This point deserves its own slide.
> And perhaps a little more explanation.
> Remember these slides are for readers now.

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:70: - Performance - "not too slow" doesn't mean fast enough
On 2013/11/04 05:42:12, adg wrote:
> "not too slow" is often not fast enough

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:72: - Magic!
On 2013/11/04 05:42:12, adg wrote:
> an example? elaborate maybe?
> ironically, this magic bullet point makes you guilty of the thing you don't
like
> :)

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:74: * And ... the infamous GIL
On 2013/11/04 05:42:12, adg wrote:
> * And I *do* like concurrency
> 
> A lot has been said about Python's infamous Global Interpreter Lock.

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:96: - Magic!
On 2013/11/04 05:42:12, adg wrote:
> again, a parenthetical listing some of these magic things might help

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:118: Conceptually complex
On 2013/11/04 05:42:12, adg wrote:
> "Mechanically complex" perhaps?

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:138: - Channels: typed, synchronized, thread-safe pipes
(the pipes)
On 2013/11/04 05:42:12, adg wrote:
> "(the pipes)" what pipes? all i see are arrows

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:142: * Goroutines to the rescue
On 2013/11/04 05:42:12, adg wrote:
> What are they saving us from?
> 
> Maybe '"Generator" goroutines' is a better title
> 
> Also you could mention in words "Uses a channel send instead of yield." 

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:158: * More about concurrency
On 2013/11/04 05:42:12, adg wrote:
> This slide could say more. For example:
> 
> * But there's much more
> 
> Goroutines and channels aren't just for generators. They can be used to model
> all kinds of concurrent systems.
> 
> To learn more:
> 
> - ... talks

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:164: * Types and methods
On 2013/11/04 05:42:12, adg wrote:
> "Object-oriented Go" ?

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:164: * Types and methods
On 2013/11/04 05:42:12, adg wrote:
> "Object-oriented Go" ?

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:174: Using it
On 2013/11/04 05:42:12, adg wrote:
> Constructing a `Name` and using it

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:192: You can define methods on types within the same
package.
On 2013/11/04 05:42:12, adg wrote:
> You can *only* define...

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:206: s/duck/file-like object/g;
On 2013/11/04 05:42:12, adg wrote:
> what's the semicolon for?

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:214: Just a set of methods.
On 2013/11/04 05:42:12, adg wrote:
> Most interfaces define a set of methods. Why are Go's "just" that?

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:216: type Reader interface {
On 2013/11/04 05:42:12, adg wrote:
> this could be fmt.Stringer instead, and you could show how the types from the
> previous slide can be passed and formatted by fmt.Println

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:226: *Implicit*satisfaction*=*No*"implements"*
On 2013/11/04 05:42:12, adg wrote:
> put this below the following statement

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:230: Structural typing: like duck typing, but checked at
compile time
On 2013/11/04 05:42:12, adg wrote:
> Perhaps: It's called "Structural typing": it doesn't just sound like a duck;
it
> *is* a duck (and this is checked at compile time)

Done in two sentences rather than one.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:236: A convenient way to wrap a function.
On 2013/11/04 05:42:12, adg wrote:
> you use closing punctuation on some slides but not on others. I don't mind
which
> way you go, but pick one and stick to it.

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:254: Not really, but close enough.
On 2013/11/04 05:42:12, adg wrote:
> "Go doesn't provide decorators in the language, but its function literal
syntax
> and simple scoping rules make it easy to do something similar.

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:282: Mostly used for testing purposes
On 2013/11/04 05:42:12, adg wrote:
> s/Mostly/Often/
> 

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:284: We want to test
On 2013/11/04 05:42:12, adg wrote:
> For example, say we want to test this function:

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:288: Which depends on
On 2013/11/04 05:42:12, adg wrote:
> Which depends on a function that makes an HTTP request:

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:294: We can test `say_hi` without modifying it and without
HTTP requests.
On 2013/11/04 05:42:12, adg wrote:
> We can test `say_hi` without making HTTP requests by stubbing out the auth
> function:

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:300: The same effect can be obtained in Go.
On 2013/11/04 05:42:12, adg wrote:
> s/obtained/achieved/

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:314: If the code is in a file with name ending in
`_test.go`, it's only compiled when running
On 2013/11/04 05:42:12, adg wrote:
> This is kinda out-of-place. you haven't talked about packages or anything yet.
> I'd consider dropping this point. It's a bad practice to stub stuff out for
> _all_ tests all the time, anyway. Usually you'd want to do it just for that
one
> test and then put the original function back once it completes.

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:316: go test
On 2013/11/04 05:42:12, adg wrote:
> $ go test

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:334: - speed
On 2013/11/04 05:42:12, adg wrote:
> fast

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:335: - concurrency
On 2013/11/04 05:42:12, adg wrote:
> concurrent

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:339: - No animals (gophers, pythons, ducks, or monkeys)
were injured during the writing of this talk.
On 2013/11/04 05:42:12, adg wrote:
> "No pythons, ducks, monkeys or gophers were harmed while writing this talk"
> 
> Sorry to reword your joke, but I think this flows better :-)

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:347: The interactive tour
On 2013/11/04 05:42:12, adg wrote:
> Learn Go from your web browser

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python.slide#newc...
2013/go4python.slide:353: .link https://groups.google.com/d/forum/Golang-Nuts
On 2013/11/04 05:42:12, adg wrote:
> no capitals

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/deco.go
File 2013/go4python/deco.go (right):

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/deco.go#ne...
2013/go4python/deco.go:21: var authSayHi = authRequired(sayHi)
On 2013/11/04 05:42:12, adg wrote:
> you don't necessarily need a new name, this could be
> 
> var sayHi = authRequired(func() {
>     fmt.Printf("Hi, %v", username)
> })

Yes, but then it's not really a decorator ... I'll mention it, but I don't want
to make it too complicated.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/deco.py
File 2013/go4python/deco.py (right):

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/deco.py#ne...
2013/go4python/deco.py:6: if username:
On 2013/11/04 05:42:12, adg wrote:
> what is "username"? it's not clear on the slides
> maybe you could use an http handler example instead?

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/fib-gen.go
File 2013/go4python/fib-gen.go (right):

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/fib-gen.go...
2013/go4python/fib-gen.go:5: func fib(n int, c chan int) {
On 2013/11/04 05:42:12, adg wrote:
> i'd put the chan argument before the n argument
> like io.Copy and fmt.Fprint, the destination comes first

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/fib-gen.go...
2013/go4python/fib-gen.go:9: c <- a // HL
On 2013/11/04 05:42:12, adg wrote:
> not sure what these highlights are supposed to signify.

On the Python code I highlight the "yield", they're analogous .

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/fib-gen.go...
2013/go4python/fib-gen.go:15: c := make(chan int)
On 2013/11/04 05:42:12, adg wrote:
> if you want to make it even more generator-like, why not have the fib function
> create and return the channel, so the call site is just like python
> 
> for x := range fib(10) {
> }

That's exactly the slide after this one :)

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/monkey.go
File 2013/go4python/monkey.go (right):

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/monkey.go#...
2013/go4python/monkey.go:15: func sayHi(usr string) {
On 2013/11/04 05:42:12, adg wrote:
> s/usr/user/g

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/typesandme...
File 2013/go4python/typesandmethods.go (right):

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/typesandme...
2013/go4python/typesandmethods.go:14: func (n Name) Format() string {
On 2013/11/04 05:42:12, adg wrote:
> s/Format/String/
> It's a stringer!

Done.

https://codereview.appspot.com/16990043/diff/110001/2013/go4python/typesandme...
2013/go4python/typesandmethods.go:20: func (s SimpleName) Format() string {
return string(s) }
On 2013/11/04 05:42:12, adg wrote:
> ditto

Done.

[adg, 2013-11-06 04:46:23]

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide
File 2013/go4python.slide (right):

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:24: Software Engineer at Google _Feb_11-Aug_12_
s/Google/&:/

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:28: - SQL compiler to C++ in Python.
"SQL to C++ translator" ? or at least "SQL to C++ compiler"

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:30: Go Developer Relations _Aug_12_ - `datetime.now()`
s/Relations/&:/

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:138: Looks like concurrency, right?
Maybe something more descriptive:

"Note the generator executes concurrently. Hmm... I like concurrency."

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:160: .image go4python/img/fib-go.png 500 304
This diagram makes the goroutines/channels more mechanically complex than
generators, because you're exposing more state.

I'd remove the vertical chan line entirely.

main  fib
    start ->
-- loop --
  <- number
-- loop --
  <- close

or at least:
- replace the words "write" and "read" with "send" and "receive"
- change the chan line to be some other kind of thing. In this diagram it looks
conceptually the same as the main and fib goroutines, when it is not.

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:164: Or even more generator-like style:
s/Or even/An/

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:170: Write a function that returns a channel, writes the
first n prime numbers in
s/in/to/

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:170: Write a function that returns a channel, writes the
first n prime numbers in
s/writes/sends/

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:170: Write a function that returns a channel, writes the
first n prime numbers in
Write a function that returns a channel and sends the first n prime numbers on
it.
?

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:187: * Exercise: Fibonnaci primes
Fibonacci

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:189: Write a `filterPrimes` function that takes a channel
of ints `cin` as a
the cin and cout words here confuse, remove them

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:192: All the prime numbers that `filterPrimes` reads from
`cin` are written
s/cin/the input channel/

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:193: into `cout`.
s/cout/the output channel/

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:199: * Solution: Fibonnaci primes
Fibonacci

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:234: There's more types than structs.
s/more/more to/

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:282: *Implicit*satisfaction*=*No*"implements"*
s/=/==/

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:284: Structural typing: it doesn't only sound like a duck,
it *is* a duck.
s/only/just/

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:316: Not really, but close enough.
s/really/exactly/

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:322: A decorator function.
s/decorator/wrapper/

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:338: * Exercise: errors in HTTP handlers
They can't do this exercise in the playground, though... :-/

Maybe adjust the main function of your example to invoke the handlers manually
with dummy requests, with a comment explaining that the network doesn't function
in the playground.

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:349: type MyHandlerFunc func(http.ResponseWriter,
*http.Reqest) error
s/MyHandlerFunc/ErrorHandler/

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:437: - concurrent
- statically typed ?

https://codereview.appspot.com/16990043/diff/160022/2013/go4python/deco.go
File 2013/go4python/deco.go (right):

https://codereview.appspot.com/16990043/diff/160022/2013/go4python/deco.go#ne...
2013/go4python/deco.go:19: func(w http.ResponseWriter, r *http.Request) {
put this on the previous line (it'll fit on the slide)

[francesc, 2013-11-06 19:17:25]

PTAL

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide
File 2013/go4python.slide (right):

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:24: Software Engineer at Google _Feb_11-Aug_12_
On 2013/11/06 04:46:24, adg wrote:
> s/Google/&:/

Done.

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:28: - SQL compiler to C++ in Python.
On 2013/11/06 04:46:24, adg wrote:
> "SQL to C++ translator" ? or at least "SQL to C++ compiler"

Done.

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:30: Go Developer Relations _Aug_12_ - `datetime.now()`
On 2013/11/06 04:46:24, adg wrote:
> s/Relations/&:/

Done.

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:138: Looks like concurrency, right?
On 2013/11/06 04:46:24, adg wrote:
> Maybe something more descriptive:
> 
> "Note the generator executes concurrently. Hmm... I like concurrency."

Done.

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:160: .image go4python/img/fib-go.png 500 304
On 2013/11/06 04:46:24, adg wrote:
> This diagram makes the goroutines/channels more mechanically complex than
> generators, because you're exposing more state.
> 
> I'd remove the vertical chan line entirely.
> 
> main  fib
>     start ->
> -- loop --
>   <- number
> -- loop --
>   <- close
> 
> or at least:
> - replace the words "write" and "read" with "send" and "receive"
> - change the chan line to be some other kind of thing. In this diagram it
looks
> conceptually the same as the main and fib goroutines, when it is not.

Done.

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:164: Or even more generator-like style:
On 2013/11/06 04:46:24, adg wrote:
> s/Or even/An/

Done.

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:170: Write a function that returns a channel, writes the
first n prime numbers in
On 2013/11/06 04:46:24, adg wrote:
> Write a function that returns a channel and sends the first n prime numbers on
> it.
> ?

Done.

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:187: * Exercise: Fibonnaci primes
On 2013/11/06 04:46:24, adg wrote:
> Fibonacci

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:189: Write a `filterPrimes` function that takes a channel
of ints `cin` as a
On 2013/11/06 04:46:24, adg wrote:
> the cin and cout words here confuse, remove them

Done.

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:192: All the prime numbers that `filterPrimes` reads from
`cin` are written
On 2013/11/06 04:46:24, adg wrote:
> s/cin/the input channel/

Done.

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:193: into `cout`.
On 2013/11/06 04:46:24, adg wrote:
> s/cout/the output channel/

Done.

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:199: * Solution: Fibonnaci primes
On 2013/11/06 04:46:24, adg wrote:
> Fibonacci

Done.

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:234: There's more types than structs.
On 2013/11/06 04:46:24, adg wrote:
> s/more/more to/

Done.

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:282: *Implicit*satisfaction*=*No*"implements"*
On 2013/11/06 04:46:24, adg wrote:
> s/=/==/

Done.

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:284: Structural typing: it doesn't only sound like a duck,
it *is* a duck.
On 2013/11/06 04:46:24, adg wrote:
> s/only/just/

Done.

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:316: Not really, but close enough.
On 2013/11/06 04:46:24, adg wrote:
> s/really/exactly/

Done.

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:322: A decorator function.
On 2013/11/06 04:46:24, adg wrote:
> s/decorator/wrapper/

Done.

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:338: * Exercise: errors in HTTP handlers
On 2013/11/06 04:46:24, adg wrote:
> They can't do this exercise in the playground, though... :-/
> 
> Maybe adjust the main function of your example to invoke the handlers manually
> with dummy requests, with a comment explaining that the network doesn't
function
> in the playground. 

Done.

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:349: type MyHandlerFunc func(http.ResponseWriter,
*http.Reqest) error
On 2013/11/06 04:46:24, adg wrote:
> s/MyHandlerFunc/ErrorHandler/

Done.

https://codereview.appspot.com/16990043/diff/160022/2013/go4python.slide#newc...
2013/go4python.slide:437: - concurrent
On 2013/11/06 04:46:24, adg wrote:
> - statically typed ?

Done.

https://codereview.appspot.com/16990043/diff/160022/2013/go4python/deco.go
File 2013/go4python/deco.go (right):

https://codereview.appspot.com/16990043/diff/160022/2013/go4python/deco.go#ne...
2013/go4python/deco.go:19: func(w http.ResponseWriter, r *http.Request) {
On 2013/11/06 04:46:24, adg wrote:
> put this on the previous line (it'll fit on the slide)

I think it's more readable done like this, and this is the first example of a
function literal than I show.

[adg, 2013-11-06 23:46:52]

LGTM

https://codereview.appspot.com/16990043/diff/200001/2013/go4python.slide
File 2013/go4python.slide (right):

https://codereview.appspot.com/16990043/diff/200001/2013/go4python.slide#newc...
2013/go4python.slide:98: - Magic! A bit of code can do much.
s/much/a lot/

https://codereview.appspot.com/16990043/diff/200001/2013/go4python.slide#newc...
2013/go4python.slide:146: .image go4python/img/fib-go.png 500 350
much nicer!

https://codereview.appspot.com/16990043/diff/200001/2013/go4python.slide#newc...
2013/go4python.slide:360: .link http://golang.org/s/go4py-ex3
this snippet doesn't execute, I get "Error communicating with remote server."
You seeing that?

[francesc, 2013-11-07 02:10:52]

*** Submitted as
https://code.google.com/p/go/source/detail?r=6872873bf350&repo=talks ***

go.talks: new talk Go for Pythonistas

R=adg
CC=golang-dev
https://codereview.appspot.com/16990043

https://codereview.appspot.com/16990043/diff/200001/2013/go4python.slide
File 2013/go4python.slide (right):

https://codereview.appspot.com/16990043/diff/200001/2013/go4python.slide#newc...
2013/go4python.slide:98: - Magic! A bit of code can do much.
On 2013/11/06 23:46:53, adg wrote:
> s/much/a lot/

Done.

https://codereview.appspot.com/16990043/diff/200001/2013/go4python.slide#newc...
2013/go4python.slide:146: .image go4python/img/fib-go.png 500 350
On 2013/11/06 23:46:53, adg wrote:
> much nicer!
thanks!

https://codereview.appspot.com/16990043/diff/200001/2013/go4python.slide#newc...
2013/go4python.slide:360: .link http://golang.org/s/go4py-ex3
On 2013/11/06 23:46:53, adg wrote:
> this snippet doesn't execute, I get "Error communicating with remote server."
> You seeing that?

The server was down, it works now (that my talk is over)