Issue 169860043: code review 169860043: database/sql: make TestDrivers not crash on second run

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 169860043: code review 169860043: database/sql: make TestDrivers not crash on second run (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 5 months ago by bradfitz

Modified:
9 years, 5 months ago

Reviewers:
iant

CC:
adg, iant, golang-codereviews

Visibility:
Public.

Description

database/sql: make TestDrivers not crash on second run Using -test.cpu=1,1 made it crash before. Fixes Issue 9024

Patch Set 1 #

Patch Set 2 : diff -r 9340f9f6dfc9120543617696123f75a3d49a69dd https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9340f9f6dfc9120543617696123f75a3d49a69dd https://go.googlecode.com/hg/ #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	src/database/sql/fakedb_test.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/database/sql/sql.go	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

9 years, 5 months ago (2014-10-31 14:02:15 UTC) #1

iant

9 years, 5 months ago (2014-10-31 16:49:42 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=0a4f829ee9ff ***

database/sql: make TestDrivers not crash on second run

Using -test.cpu=1,1 made it crash before.

Fixes Issue 9024

LGTM=iant
R=adg, iant
CC=golang-codereviews
https://codereview.appspot.com/169860043

Committer: Ian Lance Taylor <iant@golang.org>

Expand All Messages | Collapse All Messages