Issue 169730043: code review 169730043: fmt: fix documentation for %g and %G

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 169730043: code review 169730043: fmt: fix documentation for %g and %G (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 5 months ago by r

Modified:
9 years, 5 months ago

Reviewers:
jscrockett01, rsc

CC:
golang-codereviews, rsc

Visibility:
Public.

Description

fmt: fix documentation for %g and %G It now echoes what strconv.FormatFloat says. Fixes issue 9012.

Patch Set 2 : diff -r 72c99d605f991cf3317faf09b0bde66d9246e66f https://code.google.com/p/go/ #

Total comments: 1

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/fmt/doc.go	View		1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

9 years, 5 months ago (2014-10-29 03:16:33 UTC) #1

*** Submitted as https://code.google.com/p/go/source/detail?r=63346b5f91e9 *** fmt: fix documentation for %g and %G It now echoes ...

9 years, 5 months ago (2014-10-29 03:19:06 UTC) #3

jscrockett01

Typo https://codereview.appspot.com/169730043/diff/20001/src/fmt/doc.go File src/fmt/doc.go (right): https://codereview.appspot.com/169730043/diff/20001/src/fmt/doc.go#newcode42 src/fmt/doc.go:42: %G %E for large exponents, %G otherwise %F ...

9 years, 5 months ago (2014-10-29 13:19:37 UTC) #4

9 years, 5 months ago (2014-10-29 13:53:29 UTC) #5

Thanks. Fixed.


On Wed, Oct 29, 2014 at 6:19 AM, <jscrockett01@gmail.com> wrote:

> Typo
>
>
> https://codereview.appspot.com/169730043/diff/20001/src/fmt/doc.go
> File src/fmt/doc.go (right):
>
> https://codereview.appspot.com/169730043/diff/20001/src/
> fmt/doc.go#newcode42
> src/fmt/doc.go:42: %G   %E for large exponents, %G otherwise
> %F instead of %G
>
> https://codereview.appspot.com/169730043/
>

Expand All Messages | Collapse All Messages