Issue 169720043: code review 169720043: cmd/objdump: disassemble local text symbols

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 169720043: code review 169720043: cmd/objdump: disassemble local text symbols (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by iant

Modified:
9 years, 6 months ago

Reviewers:
gobot, rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

cmd/objdump: disassemble local text symbols Fixes issue 8803.

Patch Set 1 #

Patch Set 2 : diff -r 3d68989bd1ea4f9d3cc7b37433522e7d3255a280 https://code.google.com/p/go #

Patch Set 3 : diff -r 3d68989bd1ea4f9d3cc7b37433522e7d3255a280 https://code.google.com/p/go #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -3 lines)			Patch
	M	src/cmd/objdump/main.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/cmd/objdump/objdump_test.go	View		2 chunks	+17 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

iant

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

9 years, 6 months ago (2014-10-29 03:04:59 UTC) #1

iant

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.

9 years, 6 months ago (2014-10-29 03:06:35 UTC) #2

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=a49aaae9548d *** cmd/objdump: disassemble local text symbols Fixes issue 8803. LGTM=rsc R=rsc ...

9 years, 6 months ago (2014-10-29 03:25:59 UTC) #4

gobot

9 years, 6 months ago (2014-10-29 05:39:08 UTC) #5

Message was sent while issue was closed.

This CL appears to have broken the plan9-386-cnielsen builder.
See http://build.golang.org/log/f5fb5e105c7d4859468dbbd7701bcf2d373278a5

Expand All Messages | Collapse All Messages