[dev.cc] code review 169620043: runtime: convert netbsd/amd64 port to Go

runtime: convert netbsd/amd64 port to Go

[jsing, 2014-11-14 17:53:43]

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to the dev.cc branch of
https://go.googlecode.com/hg/

[jsing, 2014-11-19 12:00:16]

PTAL

[rsc, 2014-11-21 19:47:36]

LGTM

https://codereview.appspot.com/169620043/diff/60001/src/runtime/os_netbsd.go
File src/runtime/os_netbsd.go (right):

https://codereview.appspot.com/169620043/diff/60001/src/runtime/os_netbsd.go#...
src/runtime/os_netbsd.go:24: //go:noescape
delete; meaningless on function with no pointer arguments

https://codereview.appspot.com/169620043/diff/60001/src/runtime/os_netbsd.go#...
src/runtime/os_netbsd.go:41: //go:noescape
delete; meaningless on function with no pointer arguments

[jsing, 2014-11-22 05:05:16]

https://codereview.appspot.com/169620043/diff/60001/src/runtime/os_netbsd.go
File src/runtime/os_netbsd.go (right):

https://codereview.appspot.com/169620043/diff/60001/src/runtime/os_netbsd.go#...
src/runtime/os_netbsd.go:24: //go:noescape
On 2014/11/21 19:47:36, rsc wrote:
> delete; meaningless on function with no pointer arguments

Indeed. Done.

https://codereview.appspot.com/169620043/diff/60001/src/runtime/os_netbsd.go#...
src/runtime/os_netbsd.go:41: //go:noescape
On 2014/11/21 19:47:36, rsc wrote:
> delete; meaningless on function with no pointer arguments

Done.

[jsing, 2014-11-22 05:05:43]

*** Submitted as https://code.google.com/p/go/source/detail?r=ccea2c6008f0 ***

[dev.cc] runtime: convert netbsd/amd64 port to Go

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/169620043