Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(51)

Issue 1692055: code review 1692055: 1. got 29 (Mpscale) more bits of precision (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 8 months ago by ken3
Modified:
14 years, 8 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

1. got 29 (Mpscale) more bits of precision out of floating constant multiply 2. added rounding code to "const fix=float" to allow up to 29 (Mpscale) bits of slop and still get an exact fixed constant. fixes issue 931

Patch Set 1 #

Patch Set 2 : code review 1692055: 1. got 29 (Mpscale) more bits of precision #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -4 lines) Patch
M src/cmd/gc/mparith1.c View 2 chunks +32 lines, -2 lines 0 comments Download
M src/cmd/gc/mparith2.c View 1 chunk +5 lines, -1 line 0 comments Download
M src/cmd/gc/mparith3.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
ken3
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 8 months ago (2010-07-17 23:32:38 UTC) #1
ken3
14 years, 8 months ago (2010-07-17 23:32:43 UTC) #2
*** Submitted as http://code.google.com/p/go/source/detail?r=dd72bccb5a8d ***

1. got 29 (Mpscale) more bits of precision
out of floating constant multiply
2. added rounding code to "const fix=float"
to allow up to 29 (Mpscale) bits of
slop and still get an exact fixed constant.

fixes issue 931

R=rsc
CC=golang-dev
http://codereview.appspot.com/1692055
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b