code review 169010043: compiler: Do not dereference a named pointer type when ...

compiler: Do not dereference a named pointer type when looking up a method.

Fixes Issue 9018.

[cmang, 2014-11-24 14:35:56]

Hello iant@golang.org (cc: gofrontend-dev@googlegroups.com, gri@golang.org),

I'd like you to review this change to
https://code.google.com/p/gofrontend

[iant, 2014-11-24 16:07:39]

https://codereview.appspot.com/169010043/diff/40001/go/types.cc
File go/types.cc (right):

https://codereview.appspot.com/169010043/diff/40001/go/types.cc#newcode10043
go/types.cc:10043: // type, it is illegal to automatically dereference the
pointer to the
s/illegal/invalid/

(Sorry, the use of "illegal" for this meaning always bugs me.  It's not against
the law.)

[cmang, 2014-11-24 16:14:46]

https://codereview.appspot.com/169010043/diff/40001/go/types.cc
File go/types.cc (right):

https://codereview.appspot.com/169010043/diff/40001/go/types.cc#newcode10043
go/types.cc:10043: // type, it is illegal to automatically dereference the
pointer to the
On 2014/11/24 16:07:39, iant wrote:
> s/illegal/invalid/
> 
> (Sorry, the use of "illegal" for this meaning always bugs me.  It's not
against
> the law.)

Done.

[iant, 2014-11-24 17:05:32]

LGTM

[iant, 2014-11-24 17:08:51]

*** Submitted as
https://code.google.com/p/gofrontend/source/detail?r=ecb446470344 ***

compiler: Do not dereference a named pointer type when looking up a method.

Fixes Issue 9018.

LGTM=iant
R=iant
CC=gofrontend-dev, gri
https://codereview.appspot.com/169010043

Committer: Ian Lance Taylor <iant@golang.org>