Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(273)

Issue 168510043: [dev.cc] code review 168510043: runtime: convert assembly files for C to Go transition (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by rsc
Modified:
10 years, 4 months ago
Reviewers:
r, aram
CC:
r, aram, austin, dvyukov, golang-codereviews, iant, khr
Visibility:
Public.

Description

runtime: convert assembly files for C to Go transition The main change is that #include "zasm_GOOS_GOARCH.h" is now #include "go_asm.h" and/or #include "go_tls.h". Also, because C StackGuard is now Go _StackGuard, the assembly name changes from const_StackGuard to const__StackGuard. In asm_$GOARCH.s, add new function getg, formerly implemented in C. The renamed atomics now have Go wrappers, to get escape analysis annotations right. Those wrappers are in CL 174860043.

Patch Set 1 #

Patch Set 2 : diff -r 36ead9978fcc0be9de634236ad3887b41d9525e1 https://code.google.com/p/go #

Patch Set 3 : diff -r 78d8a3352e277a17b2aac08a32fe675c2bba64fd https://code.google.com/p/go #

Patch Set 4 : diff -r 022e3ed374e79747b98f073a69de1c7c6ca53efc https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -49 lines) Patch
M src/runtime/asm.s View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/runtime/asm_386.s View 1 6 chunks +13 lines, -5 lines 0 comments Download
M src/runtime/asm_amd64.s View 1 6 chunks +12 lines, -5 lines 0 comments Download
M src/runtime/asm_amd64p32.s View 1 5 chunks +11 lines, -4 lines 0 comments Download
M src/runtime/asm_arm.s View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M src/runtime/race_amd64.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/rt0_windows_amd64.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/sys_darwin_386.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/sys_darwin_amd64.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/sys_dragonfly_386.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/sys_dragonfly_amd64.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/sys_freebsd_386.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/sys_freebsd_amd64.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/sys_freebsd_arm.s View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/runtime/sys_linux_386.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/sys_linux_amd64.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/sys_linux_arm.s View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/runtime/sys_nacl_386.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/sys_nacl_amd64p32.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/sys_nacl_arm.s View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/runtime/sys_netbsd_386.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/sys_netbsd_amd64.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/sys_netbsd_arm.s View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/runtime/sys_openbsd_386.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/sys_openbsd_amd64.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/sys_plan9_386.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/sys_plan9_amd64.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/sys_solaris_amd64.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/sys_windows_386.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/sys_windows_amd64.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/thunk.s View 1 2 chunks +15 lines, -1 line 0 comments Download
M src/runtime/thunk_solaris_amd64.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/thunk_windows.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/tls_arm.s View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/vlop_arm.s View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4
rsc
Hello r (cc: austin, dvyukov, golang-codereviews@googlegroups.com, iant, khr), I'd like you to review this change ...
10 years, 4 months ago (2014-11-11 06:39:56 UTC) #1
r
LGTM
10 years, 4 months ago (2014-11-11 06:56:13 UTC) #2
aram
LGTM
10 years, 4 months ago (2014-11-11 11:36:47 UTC) #3
rsc
10 years, 4 months ago (2014-11-11 22:06:27 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=bccb1a9e20d5 ***

[dev.cc] runtime: convert assembly files for C to Go transition

The main change is that #include "zasm_GOOS_GOARCH.h"
is now #include "go_asm.h" and/or #include "go_tls.h".

Also, because C StackGuard is now Go _StackGuard,
the assembly name changes from const_StackGuard to
const__StackGuard.

In asm_$GOARCH.s, add new function getg, formerly
implemented in C.

The renamed atomics now have Go wrappers, to get
escape analysis annotations right. Those wrappers
are in CL 174860043.

LGTM=r, aram
R=r, aram
CC=austin, dvyukov, golang-codereviews, iant, khr
https://codereview.appspot.com/168510043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b