Issue 16850043: code review 16850043: blog.go: Set the AtomFieldTitle field in blog.Config.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 16850043: code review 16850043: blog.go: Set the AtomFieldTitle field in blog.Config. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by marete

Modified:
10 years, 6 months ago

Reviewers:
adg

CC:
golang-dev, adg

Visibility:
Public.

Description

blog.go: Set the AtomFieldTitle field in blog.Config. CL 16830043 removes the hard-coding of the atom feed title and replaces it with a configuration field in the Config structure in the go.tools/blog package. This CL sets that structure field.

Patch Set 1 #

Patch Set 2 : diff -r 87ab5ab12e4b https://code.google.com/p/go.blog #

Patch Set 3 : diff -r 87ab5ab12e4b https://code.google.com/p/go.blog #

Patch Set 4 : diff -r 87ab5ab12e4b https://code.google.com/p/go.blog #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	blog/blog.go	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

marete

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.blog

10 years, 6 months ago (2013-10-24 21:43:50 UTC) #1

marete

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

10 years, 6 months ago (2013-10-26 18:53:59 UTC) #2

adg

10 years, 6 months ago (2013-10-28 08:22:17 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=986b226d8a1f&repo=blog ***

blog.go: Set the AtomFieldTitle field in blog.Config.

CL 16830043 removes the hard-coding of the atom feed title and replaces
it with a configuration field in the Config structure in the
go.tools/blog package. This CL sets that structure field.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/16850043

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages