Issue 167810044: code review 167810044: runtime: fix line number in first stack frame in printe... (Closed)
Descriptionruntime: fix line number in first stack frame in printed stack trace
Originally traceback was only used for printing the stack
when an unexpected signal came in. In that case, the
initial PC is taken from the signal and should be used
unaltered. For the callers, the PC is the return address,
which might be on the line after the call; we subtract 1
to get to the CALL instruction.
Traceback is now used for a variety of things, and for
almost all of those the initial PC is a return address,
whether from getcallerpc, or gp->sched.pc, or gp->syscallpc.
In those cases, we need to subtract 1 from this initial PC,
but the traceback code had a hard rule "never subtract 1
from the initial PC", left over from the signal handling days.
Change gentraceback to take a flag that specifies whether
we are tracing a trap.
Change traceback to default to "starting with a return PC",
which is the overwhelmingly common case.
Add tracebacktrap, like traceback but starting with a trap PC.
Use tracebacktrap in signal handlers.
Fixes issue 7690.
Patch Set 1 #Patch Set 2 : diff -r 7fa57615d95007484b3dc70aff51739317ad429a https://code.google.com/p/go/ #Patch Set 3 : diff -r 7fa57615d95007484b3dc70aff51739317ad429a https://code.google.com/p/go/ #Patch Set 4 : diff -r 94c3ccfacd821df673743065940f88b0f49966e0 https://code.google.com/p/go/ #Patch Set 5 : diff -r 47166db901fffb117d14cf42c75688d09589c13e https://code.google.com/p/go/ #
MessagesTotal messages: 5
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
