Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(64)

Issue 1678054: code review 1678054: codereview: don't run gofmt with an empty file list (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 8 months ago by rsc
Modified:
14 years, 8 months ago
Reviewers:
CC:
gri, golang-dev
Visibility:
Public.

Description

codereview: don't run gofmt with an empty file list

Patch Set 1 #

Patch Set 2 : code review 1678054: codereview: don't run gofmt with an empty file list #

Patch Set 3 : code review 1678054: codereview: don't run gofmt with an empty file list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M lib/codereview/codereview.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello gri (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 8 months ago (2010-07-15 23:13:08 UTC) #1
gri
LGTM On Thu, Jul 15, 2010 at 4:13 PM, <rsc@golang.org> wrote: > Reviewers: gri, > ...
14 years, 8 months ago (2010-07-15 23:17:50 UTC) #2
rsc
14 years, 8 months ago (2010-07-15 23:43:08 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=87f6114950fc ***

codereview: don't run gofmt with an empty file list

R=gri
CC=golang-dev
http://codereview.appspot.com/1678054
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b