Issue 1676054: code review 1676054: windows: function stubs and build mods for cov and prof

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1676054: code review 1676054: windows: function stubs and build mods for cov and prof (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by Joe Poirier

Modified:
13 years, 9 months ago

Reviewers:

CC:
brainman, rsc, golang-dev

Visibility:
Public.

Description

windows: function stubs and build mods for cov and prof

Patch Set 1 #

Patch Set 2 : code review 1676054: windows: function stubs and build mods for cov and prof #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -3 lines)			Patch
M	include/libc.h	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	src/cmd/cov/Makefile	View	1 chunk	+8 lines, -1 line	0 comments	Download
M	src/cmd/prof/Makefile	View	1 chunk	+8 lines, -1 line	0 comments	Download
M	src/libmach/Makefile	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	src/libmach/windows.c	View	1 chunk	+59 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Joe Poirier

Hello alex.brainman@gmail.com, rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 9 months ago (2010-07-17 00:37:29 UTC) #1

brainman

13 years, 9 months ago (2010-07-30 01:47:17 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=b69ec24ad6dc ***

cov and prof: implement windows version (just function stubs and build mods)

R=brainman, rsc
CC=golang-dev
http://codereview.appspot.com/1676054

Committer: Alex Brainman <alex.brainman@gmail.com>

Expand All Messages | Collapse All Messages