Issue 167430043: code review 167430043: undo CL 166380043 / 0b54a0927656

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 167430043: code review 167430043: undo CL 166380043 / 0b54a0927656 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by adg

Modified:
10 years, 4 months ago

Reviewers:

CC:
bradfitz, rsc, golang-codereviews

Visibility:
Public.

Description

undo CL 166380043 / 0b54a0927656 This was a mistake; the cmd/api tool depends on an old version of go/types. ««« original CL description cmd/api: bump go.tools golden CL hash TBR=bradfitz R=rsc CC=golang-codereviews https://codereview.appspot.com/166380043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 0b54a09276563a73ecb15c5c5b156e39a7157dd8 https://code.google.com/p/go #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/api/run.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

adg

Hello bradfitz, bradfitz@golang.org, rsc, rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to ...

10 years, 4 months ago (2014-11-09 22:39:03 UTC) #1

adg

10 years, 4 months ago (2014-11-09 22:39:17 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=c0932f05ad83 ***

undo CL 166380043 / 0b54a0927656

This was a mistake; the cmd/api tool
depends on an old version of go/types.

««« original CL description
cmd/api: bump go.tools golden CL hash

TBR=bradfitz
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/166380043
»»»

TBR=bradfitz, rsc
R=bradfitz, rsc
CC=golang-codereviews
https://codereview.appspot.com/167430043

Expand All Messages | Collapse All Messages