Issue 166910043: code review 166910043: go.net/ipv6: simplify syscall shims

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 166910043: code review 166910043: go.net/ipv6: simplify syscall shims (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by mikio

Modified:
9 years, 6 months ago

Reviewers:
iant

CC:
iant, golang-codereviews

Visibility:
Public.

Description

go.net/ipv6: simplify syscall shims This CL replaces syscall duplicates with tiny syscall shims to help to add new platform support, to improve existing platform support.

Patch Set 1 : diff -r 4425282176f5e72450567ba37cdfffc8aa13196d https://code.google.com/p/go.net #

Patch Set 2 : diff -r 4425282176f5e72450567ba37cdfffc8aa13196d https://code.google.com/p/go.net #

Patch Set 3 : diff -r 4425282176f5e72450567ba37cdfffc8aa13196d https://code.google.com/p/go.net #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -106 lines)			Patch
M	ipv6/syscall_linux_386.go	View		2 chunks	+7 lines, -18 lines	0 comments	Download
R	ipv6/syscall_linux_386.s	View	1	1 chunk	+0 lines, -56 lines	0 comments	Download
R	ipv6/syscall_nosplit4_linux_386.go	View		1 chunk	+0 lines, -15 lines	0 comments	Download
R	ipv6/syscall_nosplit7_linux_386.go	View		1 chunk	+0 lines, -15 lines	0 comments	Download
M	ipv6/syscall_unix.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A	ipv6/thunk_linux_386.s	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

mikio

Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

9 years, 6 months ago (2014-10-30 08:21:02 UTC) #1

mikio

ptal > I think you can also remove the syscall_linux_386.s file. thanks.

9 years, 6 months ago (2014-10-30 22:02:23 UTC) #3

mikio

9 years, 6 months ago (2014-10-31 00:53:34 UTC) #5

*** Submitted as
https://code.google.com/p/go/source/detail?r=92e7569ca595&repo=net ***

go.net/ipv6: simplify syscall shims

This CL replaces syscall duplicates with tiny syscall shims to help
to add new platform support, to improve existing platform support.

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/166910043

Expand All Messages | Collapse All Messages