Issue 166380043: code review 166380043: cmd/api: bump go.tools golden CL hash

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 166380043: code review 166380043: cmd/api: bump go.tools golden CL hash (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by adg

Modified:
10 years, 4 months ago

Reviewers:
aram2, gobot

CC:
bradfitz, rsc, golang-codereviews

Visibility:
Public.

Description

cmd/api: bump go.tools golden CL hash

Patch Set 1 #

Patch Set 2 : diff -r fa202af120d3d8427ea5ed886d38e90e56ad8903 https://code.google.com/p/go #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/api/run.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 4 months ago (2014-11-09 22:30:29 UTC) #1

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=0b54a0927656 *** cmd/api: bump go.tools golden CL hash TBR=bradfitz R=rsc CC=golang-codereviews https://codereview.appspot.com/166380043

10 years, 4 months ago (2014-11-09 22:30:57 UTC) #2

gobot

This CL appears to have broken the solaris-amd64-smartos builder. See http://build.golang.org/log/e919323ae26f03bf6949725c08a55d6daabd053a

10 years, 4 months ago (2014-11-09 22:37:18 UTC) #3

It's real.

-- 
Aram Hăvărneanu

Expand All Messages | Collapse All Messages