code review 166160043: go.talks: use golang.org/x/... import paths

go.talks: use golang.org/x/... import paths

[adg, 2014-11-05 05:45:35]

Hello rsc (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.talks

[bradfitz, 2014-11-05 11:56:41]

LGTM
 On Nov 5, 2014 2:45 AM, <adg@golang.org> wrote:

> Reviewers: rsc,
>
> Message:
> Hello rsc (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go.talks
>
>
> Description:
> go.talks: use golang.org/x/... import paths
>
> Please review this at https://codereview.appspot.com/166160043/
>
> Affected files (+15, -14 lines):
>   M 2012/chat/both/chat.go
>   M 2012/chat/http-noembed/chat.go
>   M 2012/chat/http/chat.go
>   M 2012/chat/markov/chat.go
>   M 2012/chat/support/websocket.go
>   M 2012/insidepresent/socket.go
>   M 2012/insidepresent/socket-simple.go
>   M 2012/insidepresent/websocket.go
>   M 2013/bestpractices/funcdraw/cmd/funcdraw.go
>   M 2013/bestpractices/funcdraw/drawer/dependent.go
>   M 2014/hammers/importpath.go
>
>
> Index: 2012/chat/both/chat.go
> ===================================================================
> --- a/2012/chat/both/chat.go
> +++ b/2012/chat/both/chat.go
> @@ -10,7 +10,7 @@
>         "net/http"
>         "time"
>
> -       "code.google.com/p/go.net/websocket"
> +       "golang.org/x/net/websocket"
>  )
>
>  const listenAddr = "localhost:4000"
> Index: 2012/chat/http-noembed/chat.go
> ===================================================================
> --- a/2012/chat/http-noembed/chat.go
> +++ b/2012/chat/http-noembed/chat.go
> @@ -8,7 +8,7 @@
>         "log"
>         "net/http"
>
> -       "code.google.com/p/go.net/websocket"
> +       "golang.org/x/net/websocket"
>  )
>
>  const listenAddr = "localhost:4000"
> Index: 2012/chat/http/chat.go
> ===================================================================
> --- a/2012/chat/http/chat.go
> +++ b/2012/chat/http/chat.go
> @@ -8,7 +8,7 @@
>         "log"
>         "net/http"
>
> -       "code.google.com/p/go.net/websocket"
> +       "golang.org/x/net/websocket"
>  )
>
>  const listenAddr = "localhost:4000"
> @@ -24,7 +24,7 @@
>
>  type socket struct {
>         io.ReadWriter // HL
> -       done chan bool
> +       done          chan bool
>  }
>
>  func (s socket) Close() error {
> Index: 2012/chat/markov/chat.go
> ===================================================================
> --- a/2012/chat/markov/chat.go
> +++ b/2012/chat/markov/chat.go
> @@ -9,7 +9,7 @@
>         "net/http"
>         "time"
>
> -       "code.google.com/p/go.net/websocket"
> +       "golang.org/x/net/websocket"
>  )
>
>  const listenAddr = "localhost:4000"
> Index: 2012/chat/support/websocket.go
> ===================================================================
> --- a/2012/chat/support/websocket.go
> +++ b/2012/chat/support/websocket.go
> @@ -3,8 +3,8 @@
>  package main
>
>  import (
> -       "code.google.com/p/go.net/websocket"
>         "fmt"
> +       "golang.org/x/net/websocket"
>         "net/http"
>  )
>
> Index: 2012/insidepresent/socket-simple.go
> ===================================================================
> --- a/2012/insidepresent/socket-simple.go
> +++ b/2012/insidepresent/socket-simple.go
> @@ -17,7 +17,7 @@
>         "runtime"
>         "strconv"
>
> -       "code.google.com/p/go.net/websocket"
> +       "golang.org/x/net/websocket"
>  )
>
>  const socketPresent = true
> Index: 2012/insidepresent/socket.go
> ===================================================================
> --- a/2012/insidepresent/socket.go
> +++ b/2012/insidepresent/socket.go
> @@ -17,7 +17,7 @@
>         "runtime"
>         "strconv"
>
> -       "code.google.com/p/go.net/websocket"
> +       "golang.org/x/net/websocket"
>  )
>
>  const socketPresent = true
> @@ -87,7 +87,7 @@
>                         switch m.Kind {
>                         case "run":
>                                 proc[m.Id].Kill()
> -                               lOut := limiter(in, out) // HL
> +                               lOut := limiter(in, out)
>     // HL
>                                 proc[m.Id] = StartProcess(m.Id, m.Body,
> lOut) // HL
>                         case "kill":
>                                 proc[m.Id].Kill()
> @@ -211,6 +211,7 @@
>         w.out <- &Message{Id: w.id, Kind: w.kind, Body: string(b)}
>         return len(b), nil
>  }
> +
>  // END OMIT
>
>  // limiter returns a channel that wraps dest. Messages sent to the
> channel are
> Index: 2012/insidepresent/websocket.go
> ===================================================================
> --- a/2012/insidepresent/websocket.go
> +++ b/2012/insidepresent/websocket.go
> @@ -3,8 +3,8 @@
>  package main
>
>  import (
> -       "code.google.com/p/go.net/websocket"
>         "fmt"
> +       "golang.org/x/net/websocket"
>         "net/http"
>  )
>
> Index: 2013/bestpractices/funcdraw/cmd/funcdraw.go
> ===================================================================
> --- a/2013/bestpractices/funcdraw/cmd/funcdraw.go
> +++ b/2013/bestpractices/funcdraw/cmd/funcdraw.go
> @@ -11,8 +11,8 @@
>
>  // IMPORT OMIT
>  import (
> -       "code.google.com/p/go.talks/2013/bestpractices/funcdraw/drawer"
> -       "code.google.com/p/go.talks/2013/bestpractices/funcdraw/parser"
> +       "golang.org/x/talks/2013/bestpractices/funcdraw/drawer"
> +       "golang.org/x/talks/2013/bestpractices/funcdraw/parser"
>  )
>
>  // ENDIMPORT OMIT
> Index: 2013/bestpractices/funcdraw/drawer/dependent.go
> ===================================================================
> --- a/2013/bestpractices/funcdraw/drawer/dependent.go
> +++ b/2013/bestpractices/funcdraw/drawer/dependent.go
> @@ -6,7 +6,7 @@
>  import (
>         "image"
>
> -       "code.google.com/p/go.talks/2013/bestpractices/funcdraw/parser"
> +       "golang.org/x/talks/2013/bestpractices/funcdraw/parser"
>  )
>
>  // Draw draws an image showing a rendering of the passed ParsedFunc.
> Index: 2014/hammers/importpath.go
> ===================================================================
> --- a/2014/hammers/importpath.go
> +++ b/2014/hammers/importpath.go
> @@ -5,7 +5,7 @@
>  import (
>         "fmt"
>
> -       "code.google.com/p/go.tools/imports"
> +       "golang.org/x/tools/imports"
>  )
>
>  func main() {
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[rsc, 2014-11-06 01:53:14]

LGTM sunday

[adg, 2014-11-09 21:56:05]

*** Submitted as
https://code.google.com/p/go/source/detail?r=002656d840c0&repo=talks ***

go.talks: use golang.org/x/... import paths

LGTM=bradfitz, rsc
R=rsc, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/166160043