Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2201)

Issue 166049: code review 166049: fix calling convention and make memmove restore the g and m (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 3 months ago by kaib
Modified:
15 years, 3 months ago
Reviewers:
CC:
rsc
Visibility:
Public.

Description

fix calling convention and make memmove restore the g and m registers.

Patch Set 1 #

Patch Set 2 : code review 166049: fix calling convention and make memmove restore the g and m #

Patch Set 3 : code review 166049: fix calling convention and make memmove restore the g and m #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M src/pkg/runtime/arm/memmove.s View 1 2 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 4
kaib
Hello rsc, I'd like you to review the following change.
15 years, 3 months ago (2009-12-04 00:39:21 UTC) #1
rsc
LGTM but add a todo - we should probably move m and g to make ...
15 years, 3 months ago (2009-12-09 08:04:00 UTC) #2
kaib
will do. memmove can actually be implemented without saving m and g if we use ...
15 years, 3 months ago (2009-12-10 19:30:24 UTC) #3
kaib
15 years, 3 months ago (2009-12-10 19:42:02 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=15cde832a6a1 ***

fix calling convention and make memmove restore the g and m
registers.

R=rsc
http://codereview.appspot.com/166049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b