code review 165400043: test: remove failing cases from sinit.go

test: comment out failing cases from sinit.go

One failing case this removes is:

var bytes = []byte("hello, world")
var copy_bytes = bytes

We could handle this in the compiler, but it requires special
case for a variable that is initialized to the value of a
variable that is initialized to a string literal converted to
[]byte.  This seems an unlikely case--it never occurs in the
standrd library--and it seems unnecessary to write the code to
handle it.

If we do want to support this case, one approach is
https://codereview.appspot.com/171840043.

The other failing cases are of the form

var bx bool
var copy_bx = bx

The compiler used to initialize copy_bx to false.  However,
that led to issue 7665, since bx may be initialized in non-Go
code.  The compiler no longer assumes that bx must be false,
so copy_bx can not be statically initialized.

We can fix these with https://codereview.appspot.com/169040043
if we also pass -complete to the compiler as part of this
test.  This is OK but it's too late in the release cycle.

Fixes issue 8746.

[iant, 2014-11-03 05:07:38]

Hello rsc (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2014-11-04 15:07:02]

Can you comment out the lines instead of deleting them? The test used to
work, so I think it can be easily made to work again.

[rsc, 2014-11-04 15:07:19]

LGTM otherwise

[iant, 2014-11-04 17:41:47]

I actually have the changes to make this test cases pass.  I don't think they
should be applied at this stage in the release cycle.  And to be honest I also
don't think that one of them should be applied at all, because it is special
case code that will essentially never arise in real code.

I uploaded my changes and added them to the comments.  I will submit like this
after some time for objections.

[rsc, 2014-11-04 18:00:08]

LGTM

[iant, 2014-11-04 18:20:35]

*** Submitted as https://code.google.com/p/go/source/detail?r=f60b128afd41 ***

test: comment out failing cases from sinit.go

One failing case this removes is:

var bytes = []byte("hello, world")
var copy_bytes = bytes

We could handle this in the compiler, but it requires special
case for a variable that is initialized to the value of a
variable that is initialized to a string literal converted to
[]byte.  This seems an unlikely case--it never occurs in the
standrd library--and it seems unnecessary to write the code to
handle it.

If we do want to support this case, one approach is
https://codereview.appspot.com/171840043.

The other failing cases are of the form

var bx bool
var copy_bx = bx

The compiler used to initialize copy_bx to false.  However,
that led to issue 7665, since bx may be initialized in non-Go
code.  The compiler no longer assumes that bx must be false,
so copy_bx can not be statically initialized.

We can fix these with https://codereview.appspot.com/169040043
if we also pass -complete to the compiler as part of this
test.  This is OK but it's too late in the release cycle.

Fixes issue 8746.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/165400043

[gobot, 2014-11-04 19:56:07]

This CL appears to have broken the openbsd-amd64-rootbsd builder.
See http://build.golang.org/log/fd7be089282afbaf1738d8fe657447efee082c33

[iant, 2014-11-04 20:12:44]

False positive.

Ian
On Nov 4, 2014 11:56 AM, <gobot@golang.org> wrote:

> This CL appears to have broken the openbsd-amd64-rootbsd builder.
> See http://build.golang.org/log/fd7be089282afbaf1738d8fe657447efee082c33
>
> https://codereview.appspot.com/165400043/
>