Issue 165100: code review 165100: runtime: start new darwin/amd64 threads on correct stack,

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 165100: code review 165100: runtime: start new darwin/amd64 threads on correct stack, (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by rsc

Modified:
15 years, 3 months ago

Reviewers:

CC:
r

Visibility:
Public.

Description

runtime: start new darwin/amd64 threads on correct stack, then enable stack check.

Patch Set 1 #

Patch Set 2 : code review 165100: runtime: start new darwin/amd64 threads on correct stack, #

Patch Set 3 : code review 165100: runtime: start new darwin/amd64 threads on correct stack, #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -11 lines)			Patch
	M	src/pkg/runtime/darwin/amd64/sys.s	View	1 2	9 chunks	+13 lines, -11 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM On Dec 8, 2009, at 6:44 PM, rsc@golang.org wrote: > Reviewers: r, > > ...

15 years, 3 months ago (2009-12-09 02:57:07 UTC) #2

rsc

15 years, 3 months ago (2009-12-09 07:34:47 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=c9f65db98ce0 ***

runtime: start new darwin/amd64 threads on correct stack,
    then enable stack check.

R=r
http://codereview.appspot.com/165100

Expand All Messages | Collapse All Messages