Issue 165076: code review 165076: runtime: introduce unsafe.New and unsafe.NewArray

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 165076: code review 165076: runtime: introduce unsafe.New and unsafe.NewArray (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by rsc

Modified:
15 years, 3 months ago

Reviewers:

CC:
r

Visibility:
Public.

Description

runtime: introduce unsafe.New and unsafe.NewArray to provide functionality previously hacked in to reflect and gob.

Patch Set 2 : code review 165076: runtime: introduce unsafe.New and unsafe.NewArray #

Total comments: 3

Patch Set 3 : code review 165076: runtime: introduce unsafe.New and unsafe.NewArray #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -37 lines)			Patch
M	src/cmd/gc/builtin.c.boot	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/gc/unsafe.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/gob/decode.go	View	1 2	4 chunks	+11 lines, -15 lines	0 comments	Download
M	src/pkg/reflect/value.go	View		2 chunks	+8 lines, -17 lines	0 comments	Download
M	src/pkg/runtime/iface.c	View	1 2	3 chunks	+40 lines, -1 line	0 comments	Download
M	src/pkg/runtime/slice.c	View	1 2	2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/pkg/unsafe/unsafe.go	View		1 chunk	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM http://codereview.appspot.com/165076/diff/18/1003 File src/pkg/gob/decode.go (left): http://codereview.appspot.com/165076/diff/18/1003#oldcode365 src/pkg/gob/decode.go:365: // address of the beginning of the array. ...

15 years, 3 months ago (2009-12-07 19:51:39 UTC) #2

rsc

15 years, 3 months ago (2009-12-07 23:52:00 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=f46555136871 ***

runtime: introduce unsafe.New and unsafe.NewArray
    to provide functionality previously hacked in to
    reflect and gob.

R=r
http://codereview.appspot.com/165076

Expand All Messages | Collapse All Messages