Issue 16490043: code review 16490043: go-tour: add Type Conversions and Arrays pages

Issue 16490043: code review 16490043: go-tour: add Type Conversions and Arrays pages (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by adg

Modified:
10 years, 5 months ago

Reviewers:
r, Dominik Honnef

CC:
golang-dev, Dominik Honnef, r

Visibility:
Public.

Description

go-tour: add Type Conversions and Arrays pages Also: - small tweaks to the variables and slice examples, - a link to image/color from the images exercise. Fixes issue 168.

Patch Set 2 : diff -r 09c9009233b7 https://code.google.com/p/go-tour #

Patch Set 3 : diff -r 09c9009233b7 https://code.google.com/p/go-tour #

Total comments: 3

Patch Set 4 : diff -r cb457f732ebe https://code.google.com/p/go-tour #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -11 lines)			Patch
M	TODO	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
A	content/prog/tour/array.go	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	content/prog/tour/short-variable-declarations.go	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/prog/tour/slices.go	View		1 chunk	+1 line, -2 lines	0 comments	Download
A	content/prog/tour/type-conversions.go	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	content/prog/tour/variables.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/prog/tour/variables-with-initializers.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/tour.article	View	1 2 3	4 chunks	+40 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go-tour

10 years, 6 months ago (2013-10-24 10:41:02 UTC) #1

adg

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

10 years, 5 months ago (2013-12-04 22:03:25 UTC) #2

Dominik Honnef

LGTM https://codereview.appspot.com/16490043/diff/40001/content/tour.article File content/tour.article (right): https://codereview.appspot.com/16490043/diff/40001/content/tour.article#newcode216 content/tour.article:216: Unlike C, Go does not permit implicit type ...

10 years, 5 months ago (2013-12-05 08:45:25 UTC) #3

Dominik Honnef

On a side note, should slicing arrays be added to the "Slicing slices" slide?

10 years, 5 months ago (2013-12-05 08:53:38 UTC) #4

10 years, 5 months ago (2013-12-05 16:12:07 UTC) #5

adg

10 years, 5 months ago (2013-12-05 22:13:35 UTC) #6

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=8f9b9da0134e
***

go-tour: add Type Conversions and Arrays pages

Also:
- small tweaks to the variables and slice examples,
- a link to image/color from the images exercise.

Fixes issue 168.

R=golang-dev, dominik.honnef, r
CC=golang-dev
https://codereview.appspot.com/16490043

https://codereview.appspot.com/16490043/diff/40001/content/tour.article
File content/tour.article (right):

https://codereview.appspot.com/16490043/diff/40001/content/tour.article#newco...
content/tour.article:216: Unlike C, Go does not permit implicit type casts.
On 2013/12/05 16:12:07, r wrote:
> On 2013/12/05 08:45:26, Dominik Honnef wrote:
> > Are "cast" and "conversion" synonymous in this case? 
> 
> the problem is the phrasing not the terminology. replace this and the
following
> sentence with:
> 
> Unlike in C, in Go assignment between items of different type requires an
> explicit conversion.

Done.

Expand All Messages | Collapse All Messages