Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(905)

Issue 164140044: code review 164140044: syscall: fix ParseRoutingSockaddr with unexpected subme... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by rsc
Modified:
9 years, 5 months ago
Reviewers:
r, gobot
CC:
r, golang-codereviews, mikio, p1
Visibility:
Public.

Description

syscall: fix ParseRoutingSockaddr with unexpected submessages No easy way to test (would have to actually trigger some routing events from kernel) but the code is clearly wrong as written. If the header says there is a submessage, we need to at least skip over its bytes, not just continue to the next iteration. Fixes issue 8203.

Patch Set 1 #

Patch Set 2 : diff -r 0e9f68c2b11dba5fcbe067ffc8a674fbdd21ee84 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 0e9f68c2b11dba5fcbe067ffc8a674fbdd21ee84 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 0e9f68c2b11dba5fcbe067ffc8a674fbdd21ee84 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/syscall/route_bsd.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
rsc
Hello r (cc: golang-codereviews@googlegroups.com, mikioh.mikioh@gmail.com, p@google.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 5 months ago (2014-10-28 15:28:04 UTC) #1
r
LGTM
9 years, 5 months ago (2014-10-28 15:33:01 UTC) #2
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=8858417e2637 *** syscall: fix ParseRoutingSockaddr with unexpected submessages No easy way to ...
9 years, 5 months ago (2014-10-28 15:35:04 UTC) #3
gobot
9 years, 5 months ago (2014-10-28 16:00:43 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the openbsd-386-rootbsd builder.
See http://build.golang.org/log/71f2f58320cc956272d74caa36c221d7f4f18a7d
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b