Issue 164093: gc: better diagnosis of initialization loops

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 164093: gc: better diagnosis of initialization loops (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by rsc

Modified:
15 years, 3 months ago

Reviewers:
ken3

CC:
ken2

Visibility:
Public.

Description

gc: better diagnosis of initialization loops Fixes bug 292.

Patch Set 1 #

Patch Set 2 : code review 164093: gc: better diagnosis of initialization loops #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -8 lines)			Patch
M	src/cmd/gc/closure.c	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/cmd/gc/dcl.c	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/gc/go.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/gc/sinit.c	View	1	4 chunks	+64 lines, -5 lines	0 comments	Download
M	src/cmd/gc/subr.c	View		1 chunk	+0 lines, -1 line	0 comments	Download
A	test/fixedbugs/bug223.go	View		1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=17067df46d0c *** gc: better diagnosis of initialization loops Fixes bug 292. R=ken2 ...

15 years, 3 months ago (2009-12-03 08:51:06 UTC) #1

ken3

15 years, 3 months ago (2009-12-03 20:50:49 UTC) #2

On 2009/12/03 08:51:06, rsc wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=17067df46d0c ***
> 
> gc: better diagnosis of initialization loops
> 
> Fixes bug 292.
> 
> R=ken2
> http://codereview.appspot.com/164093

LGTM

Expand All Messages | Collapse All Messages