code review 164073: gofmt: race condition in error reporting and setting ex...

gofmt: race condition in error reporting and setting exit code

How to reproduce:

	$ mkdir /tmp/foo
	$ cp /dev/null /tmp/foo/bar.go
	$ chmod -r /tmp/foo/bar.go
	$ gofmt /tmp/foo
	open /tmp/foo/bar.go: permission denied
	$ echo $?		# should echo 2
	0
	$

Maybe you need to put a call to time.Sleep at the beginning of report().

[fhs, 2009-12-02 06:58:43]

Hello gri (cc: golang-dev@googlegroups.com),

I'd like you to review the following change.

[gri, 2009-12-02 20:56:28]

LGTM

Good catch. Thank you!

[gri, 2009-12-02 21:02:43]

*** Submitted as http://code.google.com/p/go/source/detail?r=8b6a929769a2 ***

gofmt: race condition in error reporting and setting exit code

How to reproduce:

	$ mkdir /tmp/foo
	$ cp /dev/null /tmp/foo/bar.go
	$ chmod -r /tmp/foo/bar.go
	$ gofmt /tmp/foo
	open /tmp/foo/bar.go: permission denied
	$ echo $?		# should echo 2
	0
	$

Maybe you need to put a call to time.Sleep at the beginning of report().

R=gri
CC=golang-dev
http://codereview.appspot.com/164073

Committer: Robert Griesemer <gri@golang.org>