code review 164049: Ported godefs to Windows.

Ported godefs to Windows.

[hector, 2009-11-30 22:48:00]

Hello rsc,

I'd like you to review the following change.

[rsc, 2009-11-30 23:28:04]

Thanks.

http://codereview.appspot.com/164049/diff/1009/5
File lib/codereview/codereview.py (right):

http://codereview.appspot.com/164049/diff/1009/5#newcode171
lib/codereview/codereview.py:171: if sys.platform == "win32":
can use and instead

if sys.platform == "win32" and os.path.isfile(path):

http://codereview.appspot.com/164049/diff/1009/6
File src/cmd/godefs/main.c (right):

http://codereview.appspot.com/164049/diff/1009/6#newcode156
src/cmd/godefs/main.c:156: #ifdef __MINGW32__
As usual I would like to minimize the ifdefs,
which make the code hard to follow.
Can we get this down to one at the top of the file:

#ifdef MINGW
int
spawnvp(char *prog, char **av)
{
    return _spawnvp(P_NOWAIT, prog, (const char**)av);
}
void
waitfor(int pid)
{
    _cwait(0, pid, 0);
}
#else
int
spawnvp(char *prog, char **argv)
{
    // code from below moves up here
}
#endif

and then change waitpid() to waitfor(pid) below.
(there is already a waitfor in the standard build.)

http://codereview.appspot.com/164049/diff/1009/6#newcode370
src/cmd/godefs/main.c:370: Bprint(bout, "%s %lT;\n", lang->typdef, name, t);
I'm surprised this didn't come up before.
I guess most typedefs are structs. 

I'd like to keep the semicolons out of the
Go code at the top level.  Can you add a 
new field called lang->typdefend that is
";\n" in C and "\n" in Go and print that
instead of the hard-coded ;\n that is there
now?

That seems more in keeping with the struct
and union code.

[hector, 2009-12-05 20:07:28]

PTAL
Checked on Linux, seems to work ok.

[rsc, 2009-12-07 18:16:51]

looks good; one nit.
please make the change,
hg upload, and let me know
once you've done that
and i will apply it.

thanks!

http://codereview.appspot.com/164049/diff/3001/3004
File src/cmd/godefs/main.c (right):

http://codereview.appspot.com/164049/diff/3001/3004#newcode236
src/cmd/godefs/main.c:236: av[n-1] = argv[i++];
it took me a long time to find this i++.
please change this to argv[i] and change
the loop to

for(i=0; i==0 || i < argc; i++)

[hector, 2009-12-12 15:30:33]

Done.

2009/12/7  <rsc@golang.org>:
> looks good; one nit.
> please make the change,
> hg upload, and let me know
> once you've done that
> and i will apply it.
>
> thanks!
>
>
>
> http://codereview.appspot.com/164049/diff/3001/3004
> File src/cmd/godefs/main.c (right):
>
> http://codereview.appspot.com/164049/diff/3001/3004#newcode236
> src/cmd/godefs/main.c:236: av[n-1] = argv[i++];
> it took me a long time to find this i++.
> please change this to argv[i] and change
> the loop to
>
> for(i=0; i==0 || i < argc; i++)
>
> http://codereview.appspot.com/164049
>

[rsc, 2009-12-13 20:21:49]

*** Submitted as http://code.google.com/p/go/source/detail?r=d0f8888ee0c4 ***

Ported godefs to Windows.

R=rsc
http://codereview.appspot.com/164049

Committer: Russ Cox <rsc@golang.org>