code review 163540043: runtime: make TestCgoExternalThreadPanic run on windows

runtime: make TestCgoExternalThreadPanic run on windows

[brainman, 2014-10-29 05:28:50]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2014-10-29 13:27:36]

R=rsc,iant

(Alex, be sure to cc people on code reviews these days. By default very few
people see everything.)


On Tue, Oct 28, 2014 at 10:28 PM, <alex.brainman@gmail.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> runtime: make TestCgoExternalThreadPanic run on windows
>
> Please review this at https://codereview.appspot.com/163540043/
>
> Affected files (+27, -2 lines):
>   M src/runtime/crash_cgo_test.go
>
>
> Index: src/runtime/crash_cgo_test.go
> ===================================================================
> --- a/src/runtime/crash_cgo_test.go
> +++ b/src/runtime/crash_cgo_test.go
> @@ -36,10 +36,14 @@
>  }
>
>  func TestCgoExternalThreadPanic(t *testing.T) {
> -       if runtime.GOOS == "windows" || runtime.GOOS == "plan9" {
> +       if runtime.GOOS == "plan9" {
>                 t.Skipf("no pthreads on %s", runtime.GOOS)
>         }
> -       got := executeTest(t, cgoExternalThreadPanicSource, nil, "main.c",
> cgoExternalThreadPanicC)
> +       csrc := cgoExternalThreadPanicC
> +       if runtime.GOOS == "windows" {
> +               csrc = cgoExternalThreadPanicC_windows
> +       }
> +       got := executeTest(t, cgoExternalThreadPanicSource, nil, "main.c",
> csrc)
>         want := "panic: BOOM"
>         if !strings.Contains(got, want) {
>                 t.Fatalf("want failure containing %q. output:\n%s\n",
> want, got)
> @@ -169,3 +173,24 @@
>                 printf("pthread_create failed\n");
>  }
>  `
> +
> +const cgoExternalThreadPanicC_windows = `
> +#include <stdlib.h>
> +#include <stdio.h>
> +
> +void gopanic(void);
> +
> +static void*
> +die(void* x)
> +{
> +       gopanic();
> +       return 0;
> +}
> +
> +void
> +start(void)
> +{
> +       if(_beginthreadex(0, 0, die, 0, 0, 0) != 0)
> +               printf("_beginthreadex failed\n");
> +}
> +`
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[rsc, 2014-10-29 14:05:31]

LGTM

I was fine without the test, because the bug was in non-OS-specific code.
But this is good too.

[brainman, 2014-10-29 23:24:46]

*** Submitted as https://code.google.com/p/go/source/detail?r=eed6d37ef785 ***

runtime: make TestCgoExternalThreadPanic run on windows

LGTM=rsc
R=golang-codereviews, bradfitz, rsc
CC=golang-codereviews
https://codereview.appspot.com/163540043