Issue 163088: 6g etc: groundwork for eliminating redundant bounds checks.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 163088: 6g etc: groundwork for eliminating redundant bounds checks. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by rsc

Modified:
15 years, 4 months ago

Reviewers:
ken3

CC:
ken2

Visibility:
Public.

Description

6g etc: groundwork for eliminating redundant bounds checks. drop check in range over array. drop check in [256]array indexed by byte.

Patch Set 1 #

Patch Set 2 : code review 163088: 6g etc: groundwork for eliminating redundant bounds checks. #

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -22 lines)			Patch
M	src/cmd/5g/cgen.c	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/5g/gsubr.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/6g/cgen.c	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/cmd/6g/gsubr.c	View	2 chunks	+12 lines, -11 lines	0 comments	Download
M	src/cmd/8g/cgen.c	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/cmd/gc/range.c	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	src/cmd/gc/walk.c	View	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=2b5685522cb3 *** 6g etc: groundwork for eliminating redundant bounds checks. drop check ...

15 years, 4 months ago (2009-12-03 01:30:09 UTC) #1

ken3

15 years, 4 months ago (2009-12-03 01:59:26 UTC) #2

On 2009/12/03 01:30:09, rsc wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=2b5685522cb3 ***
> 
> 6g etc: groundwork for eliminating redundant bounds checks.
> 	drop check in range over array.
> 	drop check in [256]array indexed by byte.
> 
> R=ken2
> http://codereview.appspot.com/163088

LGTM

Expand All Messages | Collapse All Messages