Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(66)

Issue 163085: code review 163085: move ReadFile, WriteFile, and ReadDir into a separate i... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 3 months ago by r
Modified:
15 years, 3 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

move ReadFile, WriteFile, and ReadDir into a separate io/ioutil package. this breaks the dependency of package io on package bytes.

Patch Set 1 #

Patch Set 2 : code review 163085: move ReadFile, WriteFile, and ReadDir into a separate i... #

Patch Set 3 : code review 163085: move ReadFile, WriteFile, and ReadDir into a separate i... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -68 lines) Patch
M src/cmd/cgo/util.go View 2 chunks +3 lines, -3 lines 0 comments Download
M src/cmd/ebnflint/ebnflint.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/cmd/godoc/godoc.go View 6 chunks +6 lines, -5 lines 0 comments Download
M src/cmd/gofmt/gofmt.go View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/cmd/hgpatch/main.go View 4 chunks +5 lines, -4 lines 0 comments Download
M src/pkg/Makefile View 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/archive/tar/writer_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M src/pkg/compress/flate/deflate_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/compress/zlib/writer_test.go View 2 chunks +3 lines, -2 lines 0 comments Download
M src/pkg/debug/proc/proc_linux.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/ebnf/ebnf_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/encoding/ascii85/ascii85_test.go View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/encoding/base64/base64_test.go View 2 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/encoding/git85/git_test.go View 3 chunks +4 lines, -4 lines 0 comments Download
M src/pkg/exec/exec_test.go View 3 chunks +3 lines, -2 lines 0 comments Download
M src/pkg/exp/eval/main.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/go/parser/interface.go View 3 chunks +3 lines, -2 lines 0 comments Download
M src/pkg/go/printer/printer_test.go View 2 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/http/client_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/http/request.go View 2 chunks +2 lines, -1 line 0 comments Download
M src/pkg/io/Makefile View 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/io/io.go View 1 chunk +1 line, -2 lines 0 comments Download
A src/pkg/io/ioutil/Makefile View 1 chunk +11 lines, -0 lines 0 comments Download
M src/pkg/io/ioutil/ioutil.go View 3 chunks +6 lines, -5 lines 0 comments Download
M src/pkg/io/ioutil/ioutil_test.go View 3 chunks +4 lines, -4 lines 0 comments Download
M src/pkg/os/os_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M src/pkg/path/path.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/time/zoneinfo.go View 2 chunks +2 lines, -2 lines 0 comments Download
M test/bench/k-nucleotide.go View 2 chunks +2 lines, -2 lines 0 comments Download
M test/bench/regex-dna.go View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
r
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review the following change.
15 years, 3 months ago (2009-12-02 22:23:10 UTC) #1
rsc
LGTM gri already has the json files in a separate CL
15 years, 3 months ago (2009-12-03 05:53:26 UTC) #2
r
15 years, 3 months ago (2009-12-03 06:02:16 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=7620e54a1ccf ***

move ReadFile, WriteFile, and ReadDir into a separate io/ioutil package.
this breaks the dependency of package io on package bytes.

R=rsc
CC=golang-dev
http://codereview.appspot.com/163085
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b