Issue 163072: code review 163072: net: test and fix support for 0-length datagram packets.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 163072: code review 163072: net: test and fix support for 0-length datagram packets. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 3 months ago by rsc

Modified:
15 years, 3 months ago

Reviewers:

CC:
r, jonathan.r.hudson_gmail.com

Visibility:
Public.

Description

net: test and fix support for 0-length datagram packets. Fixes issue 274.

Patch Set 2 : code review 163072: net: test and fix support for 0-length datagram packets. #

Total comments: 3

Patch Set 3 : code review 163072: net: test and fix support for 0-length datagram packets. #

Created: 15 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -25 lines)			Patch
	M	src/pkg/net/fd.go	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
	M	src/pkg/net/server_test.go	View	1 2	5 chunks	+32 lines, -24 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: jonathan.r.hudson@gmail.com), I'd like you to review the following change.

15 years, 3 months ago (2009-12-02 08:52:27 UTC) #1

LGTM http://codereview.appspot.com/163072/diff/1003/1005 File src/pkg/net/server_test.go (right): http://codereview.appspot.com/163072/diff/1003/1005#newcode48 src/pkg/net/server_test.go:48: func connect(t *testing.T, network, addr string, zerolen bool) ...

15 years, 3 months ago (2009-12-02 16:03:36 UTC) #2

rsc

15 years, 3 months ago (2009-12-02 23:17:51 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=ef0fb478a347 ***

net: test and fix support for 0-length datagram packets.

Fixes issue 274.

R=r
CC=jonathan.r.hudson
http://codereview.appspot.com/163072

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages