Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(902)

Issue 163051: code review 163051: some godoc cleanup: (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 3 months ago by gri
Modified:
15 years, 3 months ago
Reviewers:
CC:
rsc
Visibility:
Public.

Description

some godoc cleanup: - simplified dealing with parse errors: no need to intersperse them in the source - improve visibility of highlighted identifiers by showing them in bold

Patch Set 1 #

Patch Set 2 : code review 163051: some godoc cleanup: #

Patch Set 3 : code review 163051: some godoc cleanup: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -115 lines) Patch
M doc/style.css View 1 chunk +1 line, -0 lines 0 comments Download
R lib/godoc/parseerror.html View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
R lib/godoc/parseerror.txt View 1 chunk +0 lines, -6 lines 0 comments Download
A lib/godoc/source.html View 1 chunk +13 lines, -0 lines 0 comments Download
M src/cmd/godoc/godoc.go View 1 9 chunks +27 lines, -97 lines 0 comments Download
M src/cmd/godoc/main.go View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5
gri
Hello rsc, I'd like you to review the following change.
15 years, 3 months ago (2009-12-01 03:06:49 UTC) #1
rsc
LGTM While you're hacking on godoc (not necessarily in this CL) I noticed today that ...
15 years, 3 months ago (2009-12-01 03:27:26 UTC) #2
gri
Yes, fixing of line-number handling is on my list. The next item I am tackling ...
15 years, 3 months ago (2009-12-01 17:11:45 UTC) #3
gri
*** Submitted as http://code.google.com/p/go/source/detail?r=b67c02a2b5c7 *** some godoc cleanup: - simplified dealing with parse errors: no ...
15 years, 3 months ago (2009-12-01 17:15:11 UTC) #4
rsc
15 years, 3 months ago (2009-12-02 09:52:12 UTC) #5

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b