Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7640)

Issue 163050043: code review 163050043: spec: minimal documention of unsafe.Pointer conversions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by gri
Modified:
9 years, 6 months ago
Reviewers:
r, gobot, rsc, iant
CC:
r, rsc, iant, ken2, golang-codereviews
Visibility:
Public.

Description

spec: minimal documention of unsafe.Pointer conversions Per suggestion from rsc as a result of the dicussion of (abandoned) CL 153110044. Fixes issue 7192.

Patch Set 1 #

Patch Set 2 : diff -r 38d7affdcf974191fdfeb74770ccf5874aadc1f9 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 38d7affdcf974191fdfeb74770ccf5874aadc1f9 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 14e0f632a0b4d4820aea053090338d40c0068730 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M doc/go_spec.html View 1 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7
gri
Hello r@golang.org, rsc@golang.org, iant@golang.org, ken@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to ...
9 years, 6 months ago (2014-10-23 00:28:21 UTC) #1
r
LGTM https://codereview.appspot.com/163050043/diff/40001/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/163050043/diff/40001/doc/go_spec.html#newcode6210 doc/go_spec.html:6210: must be vetted manually for type safety and ...
9 years, 6 months ago (2014-10-23 00:49:45 UTC) #2
rsc
LGTM the other places sound good to change too
9 years, 6 months ago (2014-10-23 03:56:30 UTC) #3
iant
LGTM
9 years, 6 months ago (2014-10-23 14:53:28 UTC) #4
r
https://codereview.appspot.com/162060043 On Wed, Oct 22, 2014 at 8:56 PM, <rsc@golang.org> wrote: > LGTM > the ...
9 years, 6 months ago (2014-10-23 16:00:21 UTC) #5
gri
*** Submitted as https://code.google.com/p/go/source/detail?r=5db49b99612c *** spec: minimal documention of unsafe.Pointer conversions Per suggestion from rsc ...
9 years, 6 months ago (2014-10-23 16:45:17 UTC) #6
gobot
9 years, 6 months ago (2014-10-23 16:58:14 UTC) #7
Message was sent while issue was closed.
This CL appears to have broken the plan9-amd64-aram builder.
See http://build.golang.org/log/351d6ff6c843928cd3fe92e2c512a811a54282fa
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b