code review 162770043: regexp: remove TestOnePassCutoff

regexp: remove TestOnePassCutoff

The test no longer passes, and is no longer meaningful, after
the fix for issue 7609.  It was not causing the build to break
because it is not run when using -test.short.

[iant, 2014-10-19 04:49:11]

Hello rsc (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-10-19 13:09:19]

LGTM


On Sun, Oct 19, 2014 at 6:49 AM, <iant@golang.org> wrote:

> Reviewers: rsc,
>
> Message:
> Hello rsc (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> regexp: remove TestOnePassCutoff
>
> The test no longer passes, and is no longer meaningful, after
> the fix for issue 7609.  It was not causing the build to break
> because it is not run when using -test.short.
>
> Please review this at https://codereview.appspot.com/162770043/
>
> Affected files (+0, -8 lines):
>   M src/regexp/all_test.go
>
>
> Index: src/regexp/all_test.go
> ===================================================================
> --- a/src/regexp/all_test.go
> +++ b/src/regexp/all_test.go
> @@ -473,14 +473,6 @@
>         }
>  }
>
> -// This ran out of stack before issue 7608 was fixed.
> -func TestOnePassCutoff(t *testing.T) {
> -       if testing.Short() {
> -               t.Skip("Skipping in short mode")
> -       }
> -       MustCompile(`^(?:x{1,1000}){1,1000}$`)
> -}
> -
>  func BenchmarkLiteral(b *testing.B) {
>         x := strings.Repeat("x", 50) + "y"
>         b.StopTimer()
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[rsc, 2014-10-20 14:52:14]

not lgtm

I think there is still something meaningful to test here. I'll take this over.

[iant, 2014-10-20 14:54:48]

*** Abandoned ***

[rsc, 2014-10-20 14:59:15]

Continuing in CL https://codereview.appspot.com/162860043