Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3700)

Issue 162700043: code review 162700043: go.benchmarks: use golang.org/x/... import paths (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by adg
Modified:
9 years, 5 months ago
Reviewers:
rsc, bradfitz
CC:
rsc, bradfitz, golang-codereviews
Visibility:
Public.

Description

go.benchmarks: use golang.org/x/... import paths

Patch Set 1 #

Patch Set 2 : diff -r 82cb5aac589f2985a93a882e181cfff7f07d28fc https://code.google.com/p/go.benchmarks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M bench/bench.go View 1 chunk +5 lines, -5 lines 0 comments Download
M build/build.go View 1 chunk +1 line, -1 line 0 comments Download
M garbage/garbage.go View 1 chunk +1 line, -1 line 0 comments Download
M http/http.go View 1 chunk +1 line, -1 line 0 comments Download
M json/json.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
adg
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.benchmarks
9 years, 5 months ago (2014-11-05 05:36:59 UTC) #1
bradfitz
LGTM On Nov 5, 2014 2:37 AM, <adg@golang.org> wrote: > Reviewers: rsc, > > Message: ...
9 years, 5 months ago (2014-11-05 11:57:42 UTC) #2
rsc
LGTM sunday
9 years, 5 months ago (2014-11-06 01:52:16 UTC) #3
adg
9 years, 5 months ago (2014-11-09 21:49:18 UTC) #4
*** Submitted as
https://code.google.com/p/go/source/detail?r=cc26be7d2cda&repo=benchmarks ***

go.benchmarks: use golang.org/x/... import paths

LGTM=bradfitz, rsc
R=rsc, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/162700043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b