Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(146)

Issue 162470043: code review 162470043: go.tools/cmd/godoc: add handlers for new sub-repo paths (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by adg
Modified:
9 years, 5 months ago
Reviewers:
rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

go.tools/cmd/godoc: add handlers for new sub-repo paths Fixes issue 9009.

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r 91a19f38ca4e3cc48965c6d70d40846646590928 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -0 lines) Patch
A cmd/godoc/x.go View 1 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 3
adg
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools
9 years, 5 months ago (2014-10-30 11:22:01 UTC) #1
rsc
LGTM https://codereview.appspot.com/162470043/diff/1/cmd/godoc/x.go File cmd/godoc/x.go (right): https://codereview.appspot.com/162470043/diff/1/cmd/godoc/x.go#newcode49 cmd/godoc/x.go:49: if err := xTemplate.Execute(w, struct { the formatting ...
9 years, 5 months ago (2014-10-30 14:07:58 UTC) #2
adg
9 years, 5 months ago (2014-10-30 22:01:46 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=1e73f4eb4c15&repo=tools ***

go.tools/cmd/godoc: add handlers for new sub-repo paths

Fixes issue 9009.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/162470043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b