Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15822)

Issue 162390044: code review 162390044: cmd/gc: ambiguous symbols in composite literals should ...

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by cmang
Modified:
9 years, 4 months ago
Reviewers:
rsc
CC:
rsc, golang-codereviews, gri
Visibility:
Public.

Description

cmd/gc: ambiguous symbols in composite literals should not mark an unused package as used Fixes issue 6428.

Patch Set 1 #

Patch Set 2 : diff -r b6ef09a5d00227a49dbc53a715ca9eaa3936f0d3 https://code.google.com/p/go #

Patch Set 3 : diff -r bb82d18ac07a29431c5d504d9ec354fe6346b0a0 https://code.google.com/p/go #

Patch Set 4 : diff -r bb82d18ac07a29431c5d504d9ec354fe6346b0a0 https://code.google.com/p/go #

Patch Set 5 : diff -r bb82d18ac07a29431c5d504d9ec354fe6346b0a0 https://code.google.com/p/go #

Patch Set 6 : diff -r 775e14cff1407953e14d7e7e317c6ee79b235fc7 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -13 lines) Patch
M src/cmd/gc/go.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/cmd/gc/go.y View 1 5 chunks +5 lines, -5 lines 0 comments Download
M src/cmd/gc/lex.c View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/cmd/gc/subr.c View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/gc/typecheck.c View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M src/cmd/gc/y.tab.c View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
A test/fixedbugs/issue6428a.go View 1 2 3 4 5 1 chunk +25 lines, -0 lines 0 comments Download
A test/fixedbugs/issue6428b.go View 1 2 3 4 5 1 chunk +63 lines, -0 lines 0 comments Download
A test/fixedbugs/issue6428c.go View 1 2 3 4 5 1 chunk +10 lines, -0 lines 0 comments Download
A test/fixedbugs/issue6428c.dir/a.go View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
A test/fixedbugs/issue6428c.dir/b.go View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3
cmang
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com, gri@golang.org), I'd like you to review this change to https://code.google.com/p/go
9 years, 5 months ago (2014-10-31 01:25:53 UTC) #1
rsc
LGTM but not now it's too close to the release for minor bug fixes. the ...
9 years, 5 months ago (2014-10-31 16:29:01 UTC) #2
gobot
9 years, 4 months ago (2014-12-19 05:14:47 UTC) #3
R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/162390044 is best) in the description in your
new CL.

Thanks very much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b