Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25)

Issue 1619042: code review 1619042: gc: more cleanup (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by rsc
Modified:
13 years, 10 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

gc: more cleanup * disallow surrogate pair runes. * diagnose impossible type assertions * eliminate another static buffer. * do not overflow lexbuf. * add -u flag to disable package unsafe.

Patch Set 1 #

Patch Set 2 : code review 1619042: gc: more cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -40 lines) Patch
M src/cmd/gc/go.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/gc/lex.c View 1 15 chunks +68 lines, -22 lines 0 comments Download
M src/cmd/gc/subr.c View 1 6 chunks +15 lines, -15 lines 0 comments Download
M src/cmd/gc/typecheck.c View 3 chunks +15 lines, -1 line 0 comments Download
M src/cmd/gc/unsafe.c View 1 chunk +1 line, -1 line 0 comments Download
M test/interface/explicit.go View 2 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.
13 years, 10 months ago (2010-06-09 18:00:50 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=53ba4328746e *** gc: more cleanup * disallow surrogate pair runes. * diagnose ...
13 years, 10 months ago (2010-06-09 18:01:09 UTC) #2
ken3
13 years, 10 months ago (2010-06-09 19:53:10 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b