code review 160670043: os: do not assume syscall i/o funcs return n=0 on error

os: do not assume syscall i/o funcs return n=0 on error

Fixes issue 9007.

[rsc, 2014-10-28 16:43:22]

Hello r (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[iant, 2014-10-28 16:51:44]

LGTM

[r, 2014-10-28 17:14:58]

LGTM

[rsc, 2014-10-28 19:00:19]

*** Submitted as https://code.google.com/p/go/source/detail?r=723cc35d3583 ***

os: do not assume syscall i/o funcs return n=0 on error

Fixes issue 9007.

LGTM=iant, r
R=r, iant
CC=golang-codereviews
https://codereview.appspot.com/160670043

[gobot, 2014-10-28 19:00:50]

This CL appears to have broken the android-arm-crawshaw builder.
See http://build.golang.org/log/595298c783041c6de984a98230858df15d411eda

[crawshaw, 2014-10-28 19:01:45]

Looks real:

/tmp/gobuilder/android-arm-crawshaw-723cc35d3583/go/src/os/file_unix.go:245:
cannot use int64 as type int in argument to fixCount


On Tue, Oct 28, 2014 at 3:00 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the android-arm-crawshaw builder.
> See http://build.golang.org/log/595298c783041c6de984a98230858df15d411eda
>
>
> https://codereview.appspot.com/160670043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[rsc, 2014-10-28 19:31:48]

on it. i ran a script that i thought build the go command for every single
architecture/os combo before submitting.
apparently not i guess.


On Tue, Oct 28, 2014 at 3:01 PM, David Crawshaw <crawshaw@golang.org> wrote:

> Looks real:
>
>
> /tmp/gobuilder/android-arm-crawshaw-723cc35d3583/go/src/os/file_unix.go:245:
> cannot use int64 as type int in argument to fixCount
>
>
> On Tue, Oct 28, 2014 at 3:00 PM,  <gobot@golang.org> wrote:
> > This CL appears to have broken the android-arm-crawshaw builder.
> > See http://build.golang.org/log/595298c783041c6de984a98230858df15d411eda
> >
> >
> > https://codereview.appspot.com/160670043/
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "golang-codereviews" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to golang-codereviews+unsubscribe@googlegroups.com.
> > For more options, visit https://groups.google.com/d/optout.
>