Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(57)

Issue 160030043: code review 160030043: undo CL 159990043 / 421fadcef39a (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by rsc
Modified:
9 years, 5 months ago
Reviewers:
dvyukov
CC:
golang-codereviews
Visibility:
Public.

Description

undo CL 159990043 / 421fadcef39a Dmitriy believes this broke Windows. It looks like build.golang.org stopped before that, but it's worth a shot. ««« original CL description runtime: make pprof a little nicer Update issue 8942 This does not fully address issue 8942 but it does make the profiles much more useful, until that issue can be fixed completely. LGTM=dvyukov R=r, dvyukov CC=golang-codereviews https://codereview.appspot.com/159990043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 3e5d0270f09e795f1cfd2ab7ce8897dd0cc19a1d https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M src/runtime/proc.c View 1 2 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello dvyukov (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 5 months ago (2014-10-17 14:10:54 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=0a372305e9a1 *** undo CL 159990043 / 421fadcef39a Dmitriy believes this broke Windows. ...
9 years, 5 months ago (2014-10-17 14:11:11 UTC) #2
dvyukov
LGTM I did not say that it stopped windows builders on http://build.golang.org I said that ...
9 years, 5 months ago (2014-10-17 15:44:44 UTC) #3
dvyukov
9 years, 5 months ago (2014-10-18 13:13:31 UTC) #4
Message was sent while issue was closed.
On 2014/10/17 15:44:44, dvyukov wrote:
> LGTM
> 
> I did not say that it stopped windows builders on http://build.golang.org
> I said that windows builders started failing on http://build.golang.org/perf
on
> exactly that commit

The builder stopped failing exactly on this revert:
http://build.golang.org/perf

So there was something that causes cpu profiling on windows to hang.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b