Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3759)

Issue 159910045: code review 159910045: dashboard: faster perf data fetching (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by dvyukov
Modified:
9 years, 6 months ago
Reviewers:
adg
CC:
adg, golang-codereviews, rsc
Visibility:
Public.

Description

dashboard: faster perf data fetching Use single query to fetch commit runs and metric runs (instead of individual selects). Hopefully this enables some kind of prefetching. But more importantly it allows to work around "gaps" in commit nums, as we only fetch data that is actually in the database and don't try to query all commit runs in the "gap".

Patch Set 1 #

Patch Set 2 : diff -r 66c25dc17854cba60bef390cb7c7ac6346f38e8b https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 66c25dc17854cba60bef390cb7c7ac6346f38e8b https://code.google.com/p/go.tools #

Patch Set 4 : diff -r ec0ca1bab1a835b6cf36edfefb2e919b058fbf57 https://code.google.com/p/go.tools #

Patch Set 5 : diff -r ec0ca1bab1a835b6cf36edfefb2e919b058fbf57 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -24 lines) Patch
M dashboard/app/build/build.go View 1 2 chunks +69 lines, -22 lines 0 comments Download
M dashboard/app/build/perf_graph.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M dashboard/app/build/perf_learn.go View 1 1 chunk +1 line, -1 line 0 comments Download
M dashboard/app/index.yaml View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 3
dvyukov
Hello adg@golang.org (cc: golang-codereviews@googlegroups.com, rsc@golang.org), I'd like you to review this change to https://code.google.com/p/go.tools
9 years, 6 months ago (2014-10-16 17:53:50 UTC) #1
adg
LGTM
9 years, 6 months ago (2014-10-17 07:27:53 UTC) #2
dvyukov
9 years, 6 months ago (2014-10-17 07:38:16 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=ce0e0a1d6a53&repo=tools ***

dashboard: faster perf data fetching
Use single query to fetch commit runs and metric runs (instead of individual
selects).
Hopefully this enables some kind of prefetching.
But more importantly it allows to work around "gaps" in commit nums,
as we only fetch data that is actually in the database
and don't try to query all commit runs in the "gap".

LGTM=adg
R=adg
CC=golang-codereviews, rsc
https://codereview.appspot.com/159910045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b