code review 15990043: net: ParseIP should return nil if :: doesn't expand in ...

net: ParseIP should return nil if :: doesn't expand in an IPv6 address.

Per RFC 4291, 'The use of "::" indicates one or more groups of 16 bits of zeros.'
Fixes issue 6628

[axaxs, 2013-10-23 03:23:12]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2013-10-23 14:15:01]

Thanks for the fix, but I'd like to leave this until after Go 1.2.
It's not going to cause significant problems, so the code change is not
worth the risk.

[axaxs, 2013-10-23 14:42:36]

Sure, thank you.  I wanted to go ahead and write the fix as it's something 
I needed to work correctly - I can patch it in myself of course.  However, 
what does the wait entail?  Does this get auto-deferred, or do I need to 
reply to the thread again after the 1.2 release to bring it back up?

Thanks again,
Alex

On Wednesday, October 23, 2013 10:15:00 AM UTC-4, rsc wrote:
>
> Thanks for the fix, but I'd like to leave this until after Go 1.2.
> It's not going to cause significant problems, so the code change is not 
> worth the risk.
>
>

[minux1, 2013-10-23 17:13:07]

On Oct 23, 2013 10:42 AM, <alex@lx.lc> wrote:
> Sure, thank you.  I wanted to go ahead and write the fix as it's
something I needed to work correctly - I can patch it in myself of course.
However, what does the wait entail?  Does this get auto-deferred, or do I
need to reply to the thread again after the 1.2 release to bring it back up?
you can ping this CL after 1.2 is released.

[axaxs, 2013-12-05 04:25:10]

Pinging this CL now that 1.2 is released.

Thanks,
Alex


On Wed, Oct 23, 2013 at 1:13 PM, minux <minux.ma@gmail.com> wrote:

>
> On Oct 23, 2013 10:42 AM, <alex@lx.lc> wrote:
> > Sure, thank you.  I wanted to go ahead and write the fix as it's
> something I needed to work correctly - I can patch it in myself of course.
> However, what does the wait entail?  Does this get auto-deferred, or do I
> need to reply to the thread again after the 1.2 release to bring it back up?
> you can ping this CL after 1.2 is released.
>
>

[mikio, 2013-12-20 09:33:14]

lgtm

[mikio, 2013-12-20 12:29:40]

*** Submitted as https://code.google.com/p/go/source/detail?r=9b9971d5992a ***

net: ParseIP should return nil if :: doesn't expand in an IPv6 address.

Per RFC 4291, 'The use of "::" indicates one or more groups of 16 bits of
zeros.'
Fixes issue 6628

R=golang-dev, rsc, minux.ma, mikioh.mikioh
CC=golang-dev
https://codereview.appspot.com/15990043

Committer: Mikio Hara <mikioh.mikioh@gmail.com>