Issue 159760043: code review 159760043: math/big: Fixes issue 8920

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 159760043: code review 159760043: math/big: Fixes issue 8920

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by cmars

Modified:
9 years, 6 months ago

Reviewers:
gri

CC:
golang-codereviews, gri

Visibility:
Public.

Description

math/big: Fixes issue 8920 (*Rat).SetString checks for denominator.

Patch Set 1 #

Patch Set 2 : diff -r 7b51e20e6835711435a19c304c85cc5d3df07e31 https://code.google.com/p/go #

Patch Set 3 : diff -r 095174ac8bc320d22cba5691f2f2901444ccb91d https://code.google.com/p/go #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/math/big/rat.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
	M	src/math/big/rat_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

cmars

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

9 years, 6 months ago (2014-10-13 00:53:59 UTC) #2

gri

9 years, 6 months ago (2014-10-13 19:41:20 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=0ca77a6b76c1 ***

math/big: Fixes issue 8920

(*Rat).SetString checks for denominator.

LGTM=gri
R=golang-codereviews, gri
CC=golang-codereviews
https://codereview.appspot.com/159760043

Committer: Robert Griesemer <gri@golang.org>

Expand All Messages | Collapse All Messages